[TypeDeclaration] Add test for nullable object usage on AddReturnType…

…DeclarationRector (#5887)
rectorphp · May 16, 2024 · b938e07 · b938e07
1 parent 16d1df9
commit b938e07
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 0 deletions.
diff --git a/...n/Rector/ClassMethod/AddReturnTypeDeclarationRector/Fixture/null_with_object_type.php.inc b/...n/Rector/ClassMethod/AddReturnTypeDeclarationRector/Fixture/null_with_object_type.php.inc
@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FolderInterface;
+
+class NullWithObjectType implements FolderInterface
+{
+    public function create(string $fileName)
+    {
+
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FolderInterface;
+
+class NullWithObjectType implements FolderInterface
+{
+    public function create(string $fileName): ?\Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FileInterface
+    {
+
+    }
+}
+
+?>
diff --git a/...ypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/Source/FileInterface.php b/...ypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/Source/FileInterface.php
@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source;
+
+interface FileInterface
+{}
diff --git a/...eDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/Source/FolderInterface.php b/...eDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/Source/FolderInterface.php
@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source;
+
+interface FolderInterface
+{}
diff --git a/...eDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/config/configured_rule.php b/...eDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector/config/configured_rule.php
@@ -2,6 +2,8 @@
 
 declare(strict_types=1);
 
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\StringType;
@@ -12,6 +14,8 @@
 use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Fixture\ReturnOfStatic;
 use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Fixture\ReturnTheMixed;
 use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\DataTransformerInterface;
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FileInterface;
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FolderInterface;
 use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\FormTypeInterface;
 use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector\Source\PHPUnitTestCase;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector;
@@ -31,5 +35,10 @@
             ),
             new AddReturnTypeDeclaration(DataTransformerInterface::class, 'transform', new MixedType()),
             new AddReturnTypeDeclaration(FormTypeInterface::class, 'getParent', $nullableStringType),
+            new AddReturnTypeDeclaration(
+                FolderInterface::class,
+                'create',
+                TypeCombinator::addNull(new ObjectType(FileInterface::class)),
+            ),
         ]);
 };