[Php55] Move GetCalledClassToSelfClassRector + GetCalledClassToStatic…

…ClassRector from php 7.4 to 5.5 SetList (#1972)
rectorphp · Mar 28, 2022 · a20320d · a20320d
1 parent 90bbd4e
commit a20320d
Show file tree

Hide file tree

Showing 18 changed files with 68 additions and 70 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -54,7 +54,7 @@
 
 - [Php54](#php54) (2)
 
-- [Php55](#php55) (3)
+- [Php55](#php55) (5)
 
 - [Php56](#php56) (2)
 
@@ -66,7 +66,7 @@
 
 - [Php73](#php73) (9)
 
-- [Php74](#php74) (16)
+- [Php74](#php74) (14)
 
 - [Php80](#php80) (17)
 
@@ -6740,6 +6740,44 @@ Change `__CLASS__` to self::class
 
 <br>
 
+### GetCalledClassToSelfClassRector
+
+Change `get_called_class()` to self::class on final class
+
+- class: [`Rector\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector`](../rules/Php55/Rector/FuncCall/GetCalledClassToSelfClassRector.php)
+
+```diff
+ final class SomeClass
+ {
+    public function callOnMe()
+    {
+-       var_dump(get_called_class());
++       var_dump(self::class);
+    }
+ }
+```
+
+<br>
+
+### GetCalledClassToStaticClassRector
+
+Change `get_called_class()` to static::class on non-final class
+
+- class: [`Rector\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector`](../rules/Php55/Rector/FuncCall/GetCalledClassToStaticClassRector.php)
+
+```diff
+ class SomeClass
+ {
+    public function callOnMe()
+    {
+-       var_dump(get_called_class());
++       var_dump(static::class);
+    }
+ }
+```
+
+<br>
+
 ### PregReplaceEModifierRector
 
 The /e modifier is no longer supported, use preg_replace_callback instead
@@ -7837,44 +7875,6 @@ Change `filter_var()` with slash escaping to `addslashes()`
 
 <br>
 
-### GetCalledClassToSelfClassRector
-
-Change `get_called_class()` to self::class on final class
-
-- class: [`Rector\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector`](../rules/Php74/Rector/FuncCall/GetCalledClassToSelfClassRector.php)
-
-```diff
- final class SomeClass
- {
-    public function callOnMe()
-    {
--       var_dump(get_called_class());
-+       var_dump(self::class);
-    }
- }
-```
-
-<br>
-
-### GetCalledClassToStaticClassRector
-
-Change `get_called_class()` to static::class on non-final class
-
-- class: [`Rector\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector`](../rules/Php74/Rector/FuncCall/GetCalledClassToStaticClassRector.php)
-
-```diff
- class SomeClass
- {
-    public function callOnMe()
-    {
--       var_dump(get_called_class());
-+       var_dump(static::class);
-    }
- }
-```
-
-<br>
-
 ### MbStrrposEncodingArgumentPositionRector
 
 Change `mb_strrpos()` encoding argument position

diff --git a/config/set/php55.php b/config/set/php55.php
@@ -3,6 +3,8 @@
 declare(strict_types=1);
 
 use Rector\Php55\Rector\Class_\ClassConstantToSelfClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector;
 use Rector\Php55\Rector\FuncCall\PregReplaceEModifierRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -12,4 +14,6 @@
     $services->set(StringClassNameToClassConstantRector::class);
     $services->set(ClassConstantToSelfClassRector::class);
     $services->set(PregReplaceEModifierRector::class);
+    $services->set(GetCalledClassToSelfClassRector::class);
+    $services->set(GetCalledClassToStaticClassRector::class);
 };
diff --git a/config/set/php74.php b/config/set/php74.php
@@ -9,8 +9,6 @@
 use Rector\Php74\Rector\FuncCall\ArrayKeyExistsOnPropertyRector;
 use Rector\Php74\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector;
 use Rector\Php74\Rector\FuncCall\FilterVarToAddSlashesRector;
-use Rector\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector;
-use Rector\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector;
 use Rector\Php74\Rector\FuncCall\MbStrrposEncodingArgumentPositionRector;
 use Rector\Php74\Rector\Function_\ReservedFnFunctionRector;
 use Rector\Php74\Rector\LNumber\AddLiteralSeparatorToNumberRector;
@@ -42,10 +40,6 @@
 
     $services->set(ExportToReflectionFunctionRector::class);
 
-    $services->set(GetCalledClassToSelfClassRector::class);
-
-    $services->set(GetCalledClassToStaticClassRector::class);
-
     $services->set(MbStrrposEncodingArgumentPositionRector::class);
 
     $services->set(RealToFloatTypeCastRector::class);

diff --git a/...assRector/Fixture/anonymous_class.php.inc → ...assRector/Fixture/anonymous_class.php.inc b/...assRector/Fixture/anonymous_class.php.inc → ...assRector/Fixture/anonymous_class.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 new class {
     public function callOnMe()
@@ -13,7 +13,7 @@ new class {
 -----
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 new class {
     public function callOnMe()

diff --git a/...ToSelfClassRector/Fixture/fixture.php.inc → ...ToSelfClassRector/Fixture/fixture.php.inc b/...ToSelfClassRector/Fixture/fixture.php.inc → ...ToSelfClassRector/Fixture/fixture.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 final class Fixture
 {
@@ -14,7 +14,7 @@ final class Fixture
 -----
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 final class Fixture
 {

diff --git a/...r/Fixture/skip_on_non_final_class.php.inc → ...r/Fixture/skip_on_non_final_class.php.inc b/...r/Fixture/skip_on_non_final_class.php.inc → ...r/Fixture/skip_on_non_final_class.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 class SkipOnNonFinalClass
 {

diff --git a/...elfClassRector/Fixture/skip_trait.php.inc → ...elfClassRector/Fixture/skip_trait.php.inc b/...elfClassRector/Fixture/skip_trait.php.inc → ...elfClassRector/Fixture/skip_trait.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\Fixture;
 
 trait SkipTrait
 {

diff --git a/...r/GetCalledClassToSelfClassRectorTest.php → ...r/GetCalledClassToSelfClassRectorTest.php b/...r/GetCalledClassToSelfClassRectorTest.php → ...r/GetCalledClassToSelfClassRectorTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector;
 
 use Iterator;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;

diff --git a/...elfClassRector/config/configured_rule.php → ...elfClassRector/config/configured_rule.php b/...elfClassRector/config/configured_rule.php → ...elfClassRector/config/configured_rule.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-use Rector\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {

diff --git a/...StaticClassRector/Fixture/fixture.php.inc → ...StaticClassRector/Fixture/fixture.php.inc b/...StaticClassRector/Fixture/fixture.php.inc → ...StaticClassRector/Fixture/fixture.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 class Fixture
 {
@@ -14,7 +14,7 @@ class Fixture
 -----
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 class Fixture
 {

diff --git a/...ctor/Fixture/skip_anonymous_class.php.inc → ...ctor/Fixture/skip_anonymous_class.php.inc b/...ctor/Fixture/skip_anonymous_class.php.inc → ...ctor/Fixture/skip_anonymous_class.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 new class {
     public function callOnMe()

diff --git a/...ector/Fixture/skip_on_final_class.php.inc → ...ector/Fixture/skip_on_final_class.php.inc b/...ector/Fixture/skip_on_final_class.php.inc → ...ector/Fixture/skip_on_final_class.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 final class SkipOnFinalClass
 {

diff --git a/...ticClassRector/Fixture/some_trait.php.inc → ...ticClassRector/Fixture/some_trait.php.inc b/...ticClassRector/Fixture/some_trait.php.inc → ...ticClassRector/Fixture/some_trait.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 trait SomeTrait
 {
@@ -14,7 +14,7 @@ trait SomeTrait
 -----
 <?php
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\Fixture;
 
 trait SomeTrait
 {

diff --git a/...GetCalledClassToStaticClassRectorTest.php → ...GetCalledClassToStaticClassRectorTest.php b/...GetCalledClassToStaticClassRectorTest.php → ...GetCalledClassToStaticClassRectorTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector;
+namespace Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector;
 
 use Iterator;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;

diff --git a/...ticClassRector/config/configured_rule.php → ...ticClassRector/config/configured_rule.php b/...ticClassRector/config/configured_rule.php → ...ticClassRector/config/configured_rule.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-use Rector\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {

diff --git a/...cCall/GetCalledClassToSelfClassRector.php → ...cCall/GetCalledClassToSelfClassRector.php b/...cCall/GetCalledClassToSelfClassRector.php → ...cCall/GetCalledClassToSelfClassRector.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Php74\Rector\FuncCall;
+namespace Rector\Php55\Rector\FuncCall;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
@@ -16,9 +16,9 @@
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**
- * @changelog https://wiki.php.net/rfc/deprecations_php_7_4 (not confirmed yet)
+ * @changelog https://www.php.net/ChangeLog-5.php#5.5.0
  * @see https://3v4l.org/GU9dP
- * @see \Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector\GetCalledClassToSelfClassRectorTest
+ * @see \Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector\GetCalledClassToSelfClassRectorTest
  */
 final class GetCalledClassToSelfClassRector extends AbstractRector implements MinPhpVersionInterface
 {

diff --git a/...all/GetCalledClassToStaticClassRector.php → ...all/GetCalledClassToStaticClassRector.php b/...all/GetCalledClassToStaticClassRector.php → ...all/GetCalledClassToStaticClassRector.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Php74\Rector\FuncCall;
+namespace Rector\Php55\Rector\FuncCall;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
@@ -16,9 +16,9 @@
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**
- * @changelog https://wiki.php.net/rfc/deprecations_php_7_4 (not confirmed yet)
+ * @changelog https://www.php.net/ChangeLog-5.php#5.5.0
  * @see https://3v4l.org/dJgXd
- * @see \Rector\Tests\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector\GetCalledClassToStaticClassRectorTest
+ * @see \Rector\Tests\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector\GetCalledClassToStaticClassRectorTest
  */
 final class GetCalledClassToStaticClassRector extends AbstractRector implements MinPhpVersionInterface
 {

diff --git a/tests/Issues/GetCalledClassToSelfAndStatic/config/configured_rule.php b/tests/Issues/GetCalledClassToSelfAndStatic/config/configured_rule.php
@@ -2,8 +2,8 @@
 
 declare(strict_types=1);
 
-use Rector\Php74\Rector\FuncCall\GetCalledClassToSelfClassRector;
-use Rector\Php74\Rector\FuncCall\GetCalledClassToStaticClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector;
+use Rector\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {