enable symlinks by default

rectorphp · Apr 20, 2022 · 94af16d · 94af16d
1 parent 187fd3f
commit 94af16d
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 27 deletions.
diff --git a/src/Configuration/Option.php b/src/Configuration/Option.php
@@ -200,6 +200,7 @@ final class Option
     public const PARALLEL_TIMEOUT_IN_SECONDS = 'parallel-timeout-in-seconds';
 
     /**
+     * @deprecated Symlinks are enabled by default.
      * @var string
      */
     public const FOLLOW_SYMLINKS = 'follow-symlinks';

diff --git a/src/FileSystem/FilesFinder.php b/src/FileSystem/FilesFinder.php
@@ -81,11 +81,8 @@ private function findInDirectories(array $directories, array $suffixes): array
             // skip empty files
             ->size('> 0')
             ->in($directories)
-            ->sortByName();
-
-        if ($this->hasFollowLinks()) {
-            $finder->followLinks();
-        }
+            ->sortByName()
+            ->followLinks();
 
         if ($suffixes !== []) {
             $suffixesPattern = $this->normalizeSuffixesToPattern($suffixes);

diff --git a/tests/FileSystem/FilesFinder/FilesFinderTest.php b/tests/FileSystem/FilesFinder/FilesFinderTest.php
@@ -19,14 +19,6 @@ protected function setUp(): void
         $this->filesFinder = $this->getService(FilesFinder::class);
     }
 
-    public function testWithoutFollowingSymlinks(): void
-    {
-        $this->bootFromConfigFiles([__DIR__ . '/config/disable_follow_symlinks.php']);
-        $filesFinder = $this->getService(FilesFinder::class);
-        $foundFiles = $filesFinder->findInDirectoriesAndFiles([__DIR__ . '/SourceWithSymlinks'], ['txt']);
-        $this->assertCount(1, $foundFiles);
-    }
-
     public function testWithFollowingSymlinks(): void
     {
         $this->bootFromConfigFiles([__DIR__ . '/config/enable_follow_symlinks.php']);

diff --git a/tests/FileSystem/FilesFinder/config/disable_follow_symlinks.php b/tests/FileSystem/FilesFinder/config/disable_follow_symlinks.php
diff --git a/tests/FileSystem/FilesFinder/config/enable_follow_symlinks.php b/tests/FileSystem/FilesFinder/config/enable_follow_symlinks.php
@@ -3,9 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\Configuration\Option;
 
 return static function (RectorConfig $rectorConfig): void {
-    $parameters = $rectorConfig->parameters();
-    $parameters->set(Option::FOLLOW_SYMLINKS, true);
 };