[cs] add static lambda rule [closes #2514]

bin/generate-changelog.php

@@ -73,7 +73,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $commitLines = $this->resolveCommitLinesFromToHashes($fromCommit, $toCommit);
 
-        $commits = array_map(function (string $line): array {
+        $commits = array_map(static function (string $line): array {
             [$hash, $message] = explode(' ', $line, 2);
             return [
                 self::HASH => $hash,

ecs.php

@@ -4,6 +4,7 @@
 
 use PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\AssignmentInConditionSniff;
 use PhpCsFixer\Fixer\FunctionNotation\FunctionTypehintSpaceFixer;
+use PhpCsFixer\Fixer\FunctionNotation\StaticLambdaFixer;
 use PhpCsFixer\Fixer\Phpdoc\GeneralPhpdocAnnotationRemoveFixer;
 use PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer;
 use PhpCsFixer\Fixer\Phpdoc\PhpdocNoEmptyReturnFixer;
@@ -50,6 +51,8 @@
         ],
     ]);
 
+    $ecsConfig->rule(StaticLambdaFixer::class);
+
     $ecsConfig->skip([
         '*/Source/*',
         '*/Fixture/*',

packages/BetterPhpDocParser/Comment/CommentsMerger.php

@@ -78,7 +78,7 @@ private function collectChildrenComments(Node $node): array
     {
         $childrenComments = [];
 
-        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($node, function (Node $node) use (
+        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($node, static function (Node $node) use (
             &$childrenComments
         ) {
             $comments = $node->getComments();

packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php

@@ -122,7 +122,7 @@ public function getTagsByName(string $name): array
         $tags = $this->phpDocNode->getTags();
         $name = $this->annotationNaming->normalizeName($name);
 
-        $tags = array_filter($tags, fn (PhpDocTagNode $tag): bool => $tag->name === $name);
+        $tags = array_filter($tags, static fn (PhpDocTagNode $tag): bool => $tag->name === $name);
 
         $tags = array_values($tags);
         return array_values($tags);

packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTagRemover.php

@@ -40,7 +40,7 @@ public function removeTagValueFromNode(PhpDocInfo $phpDocInfo, Node $desiredNode
         $phpDocNode = $phpDocInfo->getPhpDocNode();
 
         $phpDocNodeTraverser = new PhpDocNodeTraverser();
-        $phpDocNodeTraverser->traverseWithCallable($phpDocNode, '', function ($node) use (
+        $phpDocNodeTraverser->traverseWithCallable($phpDocNode, '', static function ($node) use (
             $desiredNode,
             $phpDocInfo
         ): ?int {

packages/BetterPhpDocParser/PhpDocNodeFinder/PhpDocNodeByTypeFinder.php

@@ -24,7 +24,7 @@ public function findByType(PhpDocNode $phpDocNode, string $desiredType): array
 
         $foundNodes = [];
 
-        $phpDocNodeTraverser->traverseWithCallable($phpDocNode, '', function ($node) use (
+        $phpDocNodeTraverser->traverseWithCallable($phpDocNode, '', static function ($node) use (
             &$foundNodes,
             $desiredType
         ): Node {

packages/Config/RectorConfig.php

@@ -125,7 +125,7 @@ public function ruleWithConfiguration(string $rectorClass, array $configuration)
         $services = $this->services();
 
         // decorate with value object inliner so Symfony understands, see https://getrector.org/blog/2020/09/07/how-to-inline-value-object-in-symfony-php-config
-        array_walk_recursive($configuration, function (&$value) {
+        array_walk_recursive($configuration, static function (&$value) {
             if (is_object($value)) {
                 $value = ValueObjectInliner::inline($value);
             }

packages/NodeTypeResolver/NodeTypeCorrector/PregMatchTypeCorrector.php

@@ -88,7 +88,7 @@ private function getVariableUsages(Variable $variable): array
             return [];
         }
 
-        return $this->betterNodeFinder->find((array) $scope->stmts, function (Node $node) use ($variable): bool {
+        return $this->betterNodeFinder->find((array) $scope->stmts, static function (Node $node) use ($variable): bool {
             if (! $node instanceof Variable) {
                 return false;
             }

packages/NodeTypeResolver/PHPStan/TypeHasher.php

@@ -56,7 +56,7 @@ public function createTypeHash(Type $type): string
         $type = $this->normalizeObjectType($type);
 
         // normalize iterable
-        $type = TypeTraverser::map($type, function (Type $currentType, callable $traverseCallback): Type {
+        $type = TypeTraverser::map($type, static function (Type $currentType, callable $traverseCallback): Type {
             if (! $currentType instanceof ObjectType) {
                 return $traverseCallback($currentType);
             }
@@ -96,7 +96,7 @@ private function createUnionTypeHash(UnionType $unionType): string
         // change alias to non-alias
         $normalizedUnionType = TypeTraverser::map(
             $normalizedUnionType,
-            function (Type $type, callable $callable): Type {
+            static function (Type $type, callable $callable): Type {
                 if (! $type instanceof AliasedObjectType && ! $type instanceof ShortenedObjectType) {
                     return $callable($type);
                 }
@@ -110,7 +110,7 @@ function (Type $type, callable $callable): Type {
 
     private function normalizeObjectType(Type $type): Type
     {
-        return TypeTraverser::map($type, function (Type $currentType, callable $traverseCallback): Type {
+        return TypeTraverser::map($type, static function (Type $currentType, callable $traverseCallback): Type {
             if ($currentType instanceof ShortenedObjectType) {
                 return new FullyQualifiedObjectType($currentType->getFullyQualifiedName());
             }

packages/NodeTypeResolver/TypeComparator/TypeComparator.php

@@ -285,7 +285,7 @@ private function areArrayUnionConstantEqualTypes(Type $firstType, Type $secondTy
 
     private function normalizeConstantBooleanType(Type $type): Type
     {
-        return TypeTraverser::map($type, function (Type $type, callable $callable): Type {
+        return TypeTraverser::map($type, static function (Type $type, callable $callable): Type {
             if ($type instanceof ConstantBooleanType) {
                 return new BooleanType();
             }

packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeCommonTypeNarrower.php

@@ -192,7 +192,7 @@ private function filterOutNativeClassReflections(array $classReflections): array
     {
         return array_filter(
             $classReflections,
-            fn (ClassReflection $classReflection): bool => ! $classReflection->isBuiltin()
+            static fn (ClassReflection $classReflection): bool => ! $classReflection->isBuiltin()
         );
     }
 }

packages/ReadWrite/ParentNodeReadAnalyzer/ArrayDimFetchParentNodeReadAnalyzer.php

@@ -41,7 +41,7 @@ private function isLeftPartOfAssign(Expr $expr): bool
 
         return ! (bool) $this->betterNodeFinder->findFirst(
             $parentAssign->var,
-            fn (Node $node): bool => $node === $expr
+            static fn (Node $node): bool => $node === $expr
         );
     }
 }

packages/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php

@@ -142,7 +142,7 @@ private function shouldSkipChaoticClassMethods(ClassMethod $classMethod): bool
 
     private function hasClassMethodExprReturn(ClassMethod $classMethod): bool
     {
-        return (bool) $this->betterNodeFinder->findFirst((array) $classMethod->stmts, function (Node $node): bool {
+        return (bool) $this->betterNodeFinder->findFirst((array) $classMethod->stmts, static function (Node $node): bool {
             if (! $node instanceof Return_) {
                 return false;
             }

rules/CodeQuality/NodeAnalyzer/ForAnalyzer.php

@@ -99,7 +99,7 @@ public function isArrayWithKeyValueNameUnsetted(For_ $for): bool
     {
         return (bool) $this->betterNodeFinder->findFirst(
             $for->stmts,
-            function (Node $node): bool {
+            static function (Node $node): bool {
                 /** @var Node $parent */
                 $parent = $node->getAttribute(AttributeKey::PARENT_NODE);
                 if (! $parent instanceof Unset_) {

rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php

@@ -193,7 +193,7 @@ private function shouldSkipExactlyReturnDateTime(ClassMethod $classMethod): bool
     {
         $return = $this->betterNodeFinder->findFirstInFunctionLikeScoped(
             $classMethod,
-            fn (Node $node): bool => $node instanceof Return_
+            static fn (Node $node): bool => $node instanceof Return_
         );
         if (! $return instanceof Return_) {
             return false;

rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php

@@ -107,7 +107,7 @@ public function provideMinPhpVersion(): int
      */
     private function matchReturnOrAssignNode(Foreach_ $foreach): ?Node
     {
-        return $this->foreachManipulator->matchOnlyStmt($foreach, function (Node $node): ?Node {
+        return $this->foreachManipulator->matchOnlyStmt($foreach, static function (Node $node): ?Node {
             if (! $node instanceof If_) {
                 return null;
             }

rules/CodeQuality/Rector/Identical/SimplifyConditionsRector.php

@@ -73,7 +73,7 @@ private function processIdenticalAndNotIdentical(Identical $identical): ?Node
     {
         $twoNodeMatch = $this->binaryOpManipulator->matchFirstAndSecondConditionNode(
             $identical,
-            fn (Node $binaryOp): bool => $binaryOp instanceof Identical || $binaryOp instanceof NotIdentical,
+            static fn (Node $binaryOp): bool => $binaryOp instanceof Identical || $binaryOp instanceof NotIdentical,
             fn (Node $binaryOp): bool => $this->valueResolver->isTrueOrFalse($binaryOp)
         );
 

rules/CodingStyle/ClassNameImport/AliasUsesResolver.php

@@ -42,7 +42,7 @@ public function resolveFromStmts(array $stmts): array
     {
         $aliasedUses = [];
 
-        $this->useImportsTraverser->traverserStmts($stmts, function (
+        $this->useImportsTraverser->traverserStmts($stmts, static function (
             UseUse $useUse,
             string $name
         ) use (&$aliasedUses): void {

rules/CodingStyle/ClassNameImport/ShortNameResolver.php

@@ -172,7 +172,7 @@ private function resolveFromStmtsDocBlocks(array $stmts): array
             $phpDocNodeTraverser->traverseWithCallable(
                 $phpDocInfo->getPhpDocNode(),
                 '',
-                function ($node) use (&$shortNames) {
+                static function ($node) use (&$shortNames) {
                     if ($node instanceof PhpDocTagNode) {
                         $shortName = trim($node->name, '@');
                         if (StringUtils::isMatch($shortName, self::BIG_LETTER_START_REGEX)) {

rules/CodingStyle/ClassNameImport/UsedImportsResolver.php

@@ -58,7 +58,7 @@ public function resolveForStmts(array $stmts): array
             $usedImports[] = new FullyQualifiedObjectType($className);
         }
 
-        $this->useImportsTraverser->traverserStmts($stmts, function (
+        $this->useImportsTraverser->traverserStmts($stmts, static function (
             UseUse $useUse,
             string $name
         ) use (&$usedImports): void {
@@ -80,7 +80,7 @@ public function resolveFunctionImportsForStmts(array $stmts): array
     {
         $usedFunctionImports = [];
 
-        $this->useImportsTraverser->traverserStmtsForFunctions($stmts, function (
+        $this->useImportsTraverser->traverserStmtsForFunctions($stmts, static function (
             UseUse $useUse,
             string $name
         ) use (&$usedFunctionImports): void {

rules/CodingStyle/Rector/Catch_/CatchExceptionNameMatchingTypeRector.php

@@ -111,7 +111,7 @@ public function refactor(Node $node): ?Node
         $newVariableName = Strings::replace(
             lcfirst($typeShortName),
             self::STARTS_WITH_ABBREVIATION_REGEX,
-            function (array $matches): string {
+            static function (array $matches): string {
                 $output = '';
 
                 $output .= isset($matches[1]) ? strtolower((string) $matches[1]) : '';

rules/CodingStyle/Rector/Property/InlineSimplePropertyAnnotationRector.php

@@ -85,7 +85,7 @@ public function configure(array $configuration): void
         Assert::allString($configuration);
 
         $this->annotationsToConsiderForInlining = array_map(
-            fn (string $annotation): string => '@' . ltrim($annotation, '@'),
+            static fn (string $annotation): string => '@' . ltrim($annotation, '@'),
             $configuration
         );
     }

rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php

@@ -110,7 +110,7 @@ public function getParts(String_ $string, array $classNames): array
         // @see https://regex101.com/r/8nGS0F/1
         $parts = Strings::split($string->value, '#(' . implode('|', $quotedClassNames) . ')#');
 
-        return array_filter($parts, fn (string $className): bool => $className !== '');
+        return array_filter($parts, static fn (string $className): bool => $className !== '');
     }
 
     /**

rules/DeadCode/NodeCollector/NodeByTypeAndPositionCollector.php

@@ -87,7 +87,7 @@ private function sortByStart(array $nodesByTypeAndPosition): array
     {
         usort(
             $nodesByTypeAndPosition,
-            fn (VariableNodeUse $firstVariableNodeUse, VariableNodeUse $secondVariableNodeUse): int => $firstVariableNodeUse->getStartTokenPosition() <=> $secondVariableNodeUse->getStartTokenPosition()
+            static fn (VariableNodeUse $firstVariableNodeUse, VariableNodeUse $secondVariableNodeUse): int => $firstVariableNodeUse->getStartTokenPosition() <=> $secondVariableNodeUse->getStartTokenPosition()
         );
         return $nodesByTypeAndPosition;
     }

rules/DeadCode/Rector/Array_/RemoveDuplicatedArrayKeyRector.php

@@ -100,8 +100,8 @@ private function getArrayItemsWithDuplicatedKey(Array_ $array): array
     private function filterItemsWithSameKey(array $arrayItemsByKeys): array
     {
         /** @var ArrayItem[][] $arrayItemsByKeys */
-        $arrayItemsByKeys = array_filter($arrayItemsByKeys, fn (array $arrayItems): bool => count($arrayItems) > 1);
+        $arrayItemsByKeys = array_filter($arrayItemsByKeys, static fn (array $arrayItems): bool => count($arrayItems) > 1);
 
-        return array_filter($arrayItemsByKeys, fn (array $arrayItems): bool => count($arrayItems) > 1);
+        return array_filter($arrayItemsByKeys, static fn (array $arrayItems): bool => count($arrayItems) > 1);
     }
 }

rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php

@@ -158,7 +158,7 @@ private function shouldSkip(Assign $assign): bool
 
         return (bool) $this->betterNodeFinder->findFirstNext(
             $assign,
-            fn (Node $node): bool => $node instanceof Variable
+            static fn (Node $node): bool => $node instanceof Variable
         );
     }
 

rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector.php

@@ -149,7 +149,7 @@ private function replaceVariablesWithPropertyFetch(
 
         $this->traverseNodesWithCallable(
             $stmtsAware,
-            function (Node $node) use ($variableUsages, $propertyFetch): ?PropertyFetch {
+            static function (Node $node) use ($variableUsages, $propertyFetch): ?PropertyFetch {
                 if (! in_array($node, $variableUsages, true)) {
                     return null;
                 }

rules/DowngradePhp54/Rector/Closure/DowngradeThisInClosureRector.php

@@ -106,7 +106,7 @@ public function refactor(Node $node): ?Node
 
         $this->nodesToAddCollector->addNodeBeforeNode($expression, $node, $this->file->getSmartFileInfo());
 
-        $this->traverseNodesWithCallable($node, function (Node $subNode) use ($selfVariable): ?Closure {
+        $this->traverseNodesWithCallable($node, static function (Node $subNode) use ($selfVariable): ?Closure {
             if (! $subNode instanceof Closure) {
                 return null;
             }

rules/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector.php

@@ -178,7 +178,7 @@ private function createReflectionInstantiation(New_ $new, array $args): ?Expr
             /** @var Array_ $array */
             $array = $unpackedArgs[0]->value;
             $arrayItems = array_filter($array->items);
-            $new->args = array_map(fn (ArrayItem $item): Arg => new Arg($item->value), $arrayItems);
+            $new->args = array_map(static fn (ArrayItem $item): Arg => new Arg($item->value), $arrayItems);
 
             return $new;
         }

rules/DowngradePhp56/Rector/FuncCall/DowngradeArrayFilterUseConstantRector.php

@@ -139,7 +139,7 @@ private function applyArrayFilterUseBoth(array $args, Closure $closure, Variable
         ]);
         $stmts = [];
 
-        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($closure->stmts, function (Node $subNode) use (
+        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($closure->stmts, static function (Node $subNode) use (
             $variable,
             $key,
             $value,
@@ -184,7 +184,7 @@ private function applyArrayFilterUseKey(array $args, Closure $closure, Variable
         $foreach = new Foreach_($funcCall, $key);
         $stmts = [];
 
-        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($closure->stmts, function (Node $subNode) use (
+        $this->simpleCallableNodeTraverser->traverseNodesWithCallable($closure->stmts, static function (Node $subNode) use (
             $variable,
             $key,
             $arrayValue,

rules/DowngradePhp80/Rector/Expression/DowngradeMatchToSwitchRector.php

@@ -99,7 +99,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $match = $this->betterNodeFinder->findFirst($node, fn (Node $subNode): bool => $subNode instanceof Match_);
+        $match = $this->betterNodeFinder->findFirst($node, static fn (Node $subNode): bool => $subNode instanceof Match_);
         if (! $match instanceof Match_) {
             return null;
         }

rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php

@@ -170,7 +170,7 @@ private function hasThrowInAssignExpr(Assign $assign): bool
     {
         return (bool) $this->betterNodeFinder->findFirst(
             $assign->expr,
-            fn (Node $node): bool => $node instanceof Throw_
+            static fn (Node $node): bool => $node instanceof Throw_
         );
     }
 

rules/EarlyReturn/NodeFactory/InvertedIfFactory.php

@@ -59,7 +59,7 @@ private function getNextReturnExpr(If_ $if): ?Node
     {
         return $this->betterNodeFinder->findFirstNext(
             $if,
-            fn (Node $node): bool => $node instanceof Return_ && $node->expr instanceof Expr
+            static fn (Node $node): bool => $node instanceof Return_ && $node->expr instanceof Expr
         );
     }
 

rules/Naming/Naming/UseImportsResolver.php

@@ -34,7 +34,7 @@ public function resolveForNode(Node $node): array
 
         return array_filter(
             $namespace->stmts,
-            fn (Stmt $stmt): bool => $stmt instanceof Use_ || $stmt instanceof GroupUse
+            static fn (Stmt $stmt): bool => $stmt instanceof Use_ || $stmt instanceof GroupUse
         );
     }
 
@@ -51,7 +51,7 @@ public function resolveBareUsesForNode(Node $node): array
             return [];
         }
 
-        return array_filter($namespace->stmts, fn (Stmt $stmt): bool => $stmt instanceof Use_);
+        return array_filter($namespace->stmts, static fn (Stmt $stmt): bool => $stmt instanceof Use_);
     }
 
     public function resolvePrefix(Use_|GroupUse $use): string

rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php

@@ -119,6 +119,6 @@ private function getAssignsOfNew(ClassMethod $classMethod): array
         /** @var Assign[] $assigns */
         $assigns = $this->betterNodeFinder->findInstanceOf((array) $classMethod->stmts, Assign::class);
 
-        return array_filter($assigns, fn (Assign $assign): bool => $assign->expr instanceof New_);
+        return array_filter($assigns, static fn (Assign $assign): bool => $assign->expr instanceof New_);
     }
 }

rules/PSR4/Composer/PSR4AutoloadPathsProvider.php

@@ -53,7 +53,7 @@ private function removeEmptyNamespaces(array $psr4Autoloads): array
     {
         return array_filter(
             $psr4Autoloads,
-            fn (string $psr4Autoload): bool => $psr4Autoload !== '',
+            static fn (string $psr4Autoload): bool => $psr4Autoload !== '',
             ARRAY_FILTER_USE_KEY
         );
     }

rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php

@@ -119,7 +119,7 @@ private function hasNamespaceInPreviousNamespace(Namespace_ $namespace): bool
     {
         return (bool) $this->betterNodeFinder->findFirstPrevious(
             $namespace,
-            fn (Node $node): bool => $node instanceof Namespace_
+            static fn (Node $node): bool => $node instanceof Namespace_
         );
     }
 

rules/PSR4/Rector/Namespace_/MultipleClassFileToPsr4ClassesRector.php

@@ -175,7 +175,7 @@ private function findNonAnonymousClassLikes(Node $node): array
     {
         $classLikes = $this->betterNodeFinder->findInstanceOf([$node], ClassLike::class);
 
-        return array_filter($classLikes, function (ClassLike $classLike): bool {
+        return array_filter($classLikes, static function (ClassLike $classLike): bool {
             if (! $classLike instanceof Class_) {
                 return true;
             }