fix(rules): Skip readonly classes from restoring default null value. (#…

…4479) * fix(rules): Skip readonly classes from restoring default null value. * Update rules-tests/Php74/Rector/Property/RestoreDefaultNullToNullableTypePropertyRector/Fixture/skip_readonly_class.php.inc --------- Co-authored-by: Marcin Czarnecki <marcin.czarnecki@westwing.pl> Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
rectorphp · Jul 11, 2023 · 4fbeab8 · 4fbeab8
1 parent dd6a1fb
commit 4fbeab8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/...operty/RestoreDefaultNullToNullableTypePropertyRector/Fixture/skip_readonly_class.php.inc b/...operty/RestoreDefaultNullToNullableTypePropertyRector/Fixture/skip_readonly_class.php.inc
@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\RestoreDefaultNullToNullableTypePropertyRector\Fixture;
+
+final readonly class SkipReadonlyClass
+{
+    public string|null $display;
+}
diff --git a/rules/Php74/Rector/Property/RestoreDefaultNullToNullableTypePropertyRector.php b/rules/Php74/Rector/Property/RestoreDefaultNullToNullableTypePropertyRector.php
@@ -62,6 +62,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        if ($node->isReadonly()) {
+            return null;
+        }
+
         $hasChanged = false;
 
         foreach ($node->getProperties() as $property) {