[TypeDeclaration] Deprecate TypedPropertyRector as inlines doc types …

…into invalid type declarations; use split strict-type based rules instead

packages/FamilyTree/Reflection/FamilyRelationsAnalyzer.php

@@ -4,40 +4,21 @@
 
 namespace Rector\FamilyTree\Reflection;
 
-use PhpParser\Node;
-use PhpParser\Node\ComplexType;
-use PhpParser\Node\Expr\Assign;
-use PhpParser\Node\Expr\PropertyFetch;
-use PhpParser\Node\Expr\StaticPropertyFetch;
 use PhpParser\Node\Name;
-use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Class_;
-use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Interface_;
-use PhpParser\Node\Stmt\Property;
-use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ReflectionProvider;
-use PHPStan\Type\NullType;
-use PHPStan\Type\Type;
-use PHPStan\Type\UnionType;
-use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\PhpParser\AstResolver;
-use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\Core\Util\Reflection\PrivatesAccessor;
-use Rector\FamilyTree\ValueObject\PropertyType;
 use Rector\NodeNameResolver\NodeNameResolver;
-use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
-use Rector\StaticTypeMapper\StaticTypeMapper;
 
 final class FamilyRelationsAnalyzer
 {
     public function __construct(
         private readonly ReflectionProvider $reflectionProvider,
         private readonly PrivatesAccessor $privatesAccessor,
         private readonly NodeNameResolver $nodeNameResolver,
-        private readonly BetterNodeFinder $betterNodeFinder,
-        private readonly StaticTypeMapper $staticTypeMapper,
         private readonly AstResolver $astResolver,
     ) {
     }
@@ -63,52 +44,6 @@ public function getChildrenOfClassReflection(ClassReflection $desiredClassReflec
         return $childrenClassReflections;
     }
 
-    public function getPossibleUnionPropertyType(
-        Property $property,
-        Type $varType,
-        Scope $scope,
-        Name | ComplexType | null $propertyTypeNode
-    ): PropertyType {
-        if ($varType instanceof UnionType) {
-            return new PropertyType($varType, $propertyTypeNode);
-        }
-
-        $classReflection = $scope->getClassReflection();
-        if (! $classReflection instanceof ClassReflection) {
-            throw new ShouldNotHappenException();
-        }
-
-        $ancestorClassReflections = array_merge($classReflection->getParents(), $classReflection->getInterfaces());
-
-        $propertyName = $this->nodeNameResolver->getName($property);
-        $kindPropertyFetch = $this->getKindPropertyFetch($property);
-
-        foreach ($ancestorClassReflections as $ancestorClassReflection) {
-            if ($ancestorClassReflection->isSubclassOf('PHPUnit\Framework\TestCase')) {
-                continue;
-            }
-
-            $class = $this->astResolver->resolveClassFromClassReflection($ancestorClassReflection);
-            if (! $class instanceof Class_) {
-                continue;
-            }
-
-            if (! $this->isPropertyWritten($class->stmts, $propertyName, $kindPropertyFetch)) {
-                continue;
-            }
-
-            $varType = new UnionType([$varType, new NullType()]);
-            $propertyTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
-                $varType,
-                TypeKind::PROPERTY
-            );
-
-            return new PropertyType($varType, $propertyTypeNode);
-        }
-
-        return new PropertyType($varType, $propertyTypeNode);
-    }
-
     /**
      * @api
      * @return string[]
@@ -146,56 +81,4 @@ public function getClassLikeAncestorNames(Class_ | Interface_ | Name $classOrNam
         /** @var string[] $ancestorNames */
         return $ancestorNames;
     }
-
-    private function getKindPropertyFetch(Property $property): string
-    {
-        return $property->isStatic()
-            ? StaticPropertyFetch::class
-            : PropertyFetch::class;
-    }
-
-    /**
-     * @param Stmt[] $stmts
-     */
-    private function isPropertyWritten(array $stmts, string $propertyName, string $kindPropertyFetch): bool
-    {
-        return (bool) $this->betterNodeFinder->findFirst($stmts, function (Node $node) use (
-            $propertyName,
-            $kindPropertyFetch
-        ): bool {
-            if (! $node instanceof ClassMethod) {
-                return false;
-            }
-
-            if ($this->nodeNameResolver->isName($node->name, 'autowire')) {
-                return false;
-            }
-
-            return $this->isPropertyAssignedInClassMethod($node, $propertyName, $kindPropertyFetch);
-        });
-    }
-
-    private function isPropertyAssignedInClassMethod(
-        ClassMethod $classMethod,
-        string $propertyName,
-        string $kindPropertyFetch
-    ): bool {
-        if ($classMethod->stmts === null) {
-            return false;
-        }
-
-        return (bool) $this->betterNodeFinder->findFirst($classMethod->stmts, function (Node $node) use (
-            $propertyName,
-            $kindPropertyFetch
-        ): bool {
-            if (! $node instanceof Assign) {
-                return false;
-            }
-
-            return $kindPropertyFetch === $node->var::class && $this->nodeNameResolver->isName(
-                $node->var,
-                $propertyName
-            );
-        });
-    }
 }