[AutoImport][Php70] Keep FQCN on conflict last name on TernaryToNullC…

…oalescingRector (#5251)

* [AutoImport][Renaming] Keep FQCN on conflict last name on TernaryToNullCoalescingRector

* no namespace only

* add namespaced fixture

* more failing fixture

* Fixed 🎉

* comment for future

packages/PostRector/Rector/NameImportingPostRector.php

@@ -94,9 +94,15 @@ private function processNodeName(Name $name, File $file): ?Node
 
         $namespaces = array_filter(
             $file->getNewStmts(),
-            static fn (Stmt $stmt): bool => $stmt instanceof Namespace_
+            static fn (Stmt $stmt): bool => $stmt instanceof Namespace_ || $stmt instanceof FileWithoutNamespace
         );
 
+        // handle overlapped resolve last new stmts
+        // @see https://github.com/rectorphp/rector-src/pull/5251
+        if ($namespaces === []) {
+            return null;
+        }
+
         if (count($namespaces) > 1) {
             return null;
         }

tests/Issues/AutoImport/Fixture/namespaced_after_ternary_to_null_coalesce.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace App;
+
+use shop\product\business\ProductFilter;
+
+class NamespacedAfterTernaryToNullCoalesce
+{
+    private function sharedProductFilter(): void
+    {
+        $page = isset($_REQUEST['page']) ? $_REQUEST['page'] : 1;
+
+        $this->brands = Hersteller::getListForProducts(new \ProductFilter());
+    }
+
+}
+
+?>
+-----
+<?php
+
+namespace App;
+
+use shop\product\business\ProductFilter;
+
+class NamespacedAfterTernaryToNullCoalesce
+{
+    private function sharedProductFilter(): void
+    {
+        $page = $_REQUEST['page'] ?? 1;
+
+        $this->brands = Hersteller::getListForProducts(new \ProductFilter());
+    }
+
+}
+
+?>

tests/Issues/AutoImport/Fixture/no_namespace_after_ternary_to_null_coalesce.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+use shop\product\business\ProductFilter;
+
+class NoNamespaceAfterTernaryToNullCoalesce
+{
+    private function sharedProductFilter(): void
+    {
+        $page = isset($_REQUEST['page']) ? $_REQUEST['page'] : 1;
+
+        $this->brands = Hersteller::getListForProducts(new \ProductFilter());
+    }
+
+}
+
+?>
+-----
+<?php
+
+use shop\product\business\ProductFilter;
+
+class NoNamespaceAfterTernaryToNullCoalesce
+{
+    private function sharedProductFilter(): void
+    {
+        $page = $_REQUEST['page'] ?? 1;
+
+        $this->brands = Hersteller::getListForProducts(new \ProductFilter());
+    }
+
+}
+
+?>

tests/Issues/AutoImport/Fixture/no_namespace_after_ternary_to_null_coalesce_long_name.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+use shop\product\business\ProductFilter;
+
+class NoNamespaceAfterTernaryToNullCoalesceLongName
+{
+    private function sharedProductFilter(): void
+    {
+        $page = isset($_REQUEST['page']) ? $_REQUEST['page'] : 1;
+
+        $this->brands = Hersteller::getListForProducts(new \some\different\ProductFilter());
+    }
+
+}
+
+?>
+-----
+<?php
+
+use shop\product\business\ProductFilter;
+
+class NoNamespaceAfterTernaryToNullCoalesceLongName
+{
+    private function sharedProductFilter(): void
+    {
+        $page = $_REQUEST['page'] ?? 1;
+
+        $this->brands = Hersteller::getListForProducts(new \some\different\ProductFilter());
+    }
+
+}
+
+?>

tests/Issues/AutoImport/config/configured_rule.php

@@ -3,11 +3,13 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\Php70\Rector\Ternary\TernaryToNullCoalescingRector;
 use Rector\Renaming\Rector\Name\RenameClassRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->importNames();
     $rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
         'Some\Exception' => 'Some\Target\Exception',
     ]);
+    $rectorConfig->rule(TernaryToNullCoalescingRector::class);
 };