-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeQuality] Assert compare on countable #353
Merged
TomasVotruba
merged 8 commits into
rectorphp:main
from
peterfox:feature/assert-compare-on-countable
Aug 16, 2024
Merged
[CodeQuality] Assert compare on countable #353
TomasVotruba
merged 8 commits into
rectorphp:main
from
peterfox:feature/assert-compare-on-countable
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Aug 3, 2024
rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Aug 3, 2024
rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Aug 15, 2024
rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 15, 2024
rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php
Outdated
Show resolved
Hide resolved
peterfox
force-pushed
the
feature/assert-compare-on-countable
branch
from
August 15, 2024 18:46
13d80b2
to
8746d9d
Compare
samsonasik
approved these changes
Aug 16, 2024
TomasVotruba
approved these changes
Aug 16, 2024
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AssertCompareOnCountableWithMethodToAssertCountRector
Why
Based on this PHPStan PHPUnit rule it will convert comparison on Countable objects with the count method to use the
assertCount
method instead.Works with method and static method calls.