Ensure check isFirstClassCallable() before getArgs() call on CallLike (…

…#373)
rectorphp · Sep 29, 2024 · daac9f0 · daac9f0
1 parent 3f726bd
commit daac9f0
Show file tree

Hide file tree

Showing 7 changed files with 29 additions and 0 deletions.
diff --git a/rules/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector.php b/rules/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector.php
@@ -101,6 +101,11 @@ public function refactor(Node $node): ?Node
             $classReflection = $this->reflectionResolver->resolveClassReflection($node);
             if ($classReflection instanceof ClassReflection && $classReflection->hasNativeMethod($methodName)) {
                 $method = $classReflection->getNativeMethod($methodName);
+
+                if ($node->isFirstClassCallable()) {
+                    return null;
+                }
+
                 if ($method->isStatic()) {
                     $hasChanged = true;
 

diff --git a/rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php b/rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php
@@ -98,6 +98,10 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
+            if ($node->isFirstClassCallable()) {
+                return null;
+            }
+
             $hasChanged = true;
             return $this->nodeFactory->createMethodCall('this', $methodName, $node->getArgs());
         });

diff --git a/...s/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php b/...s/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php
@@ -60,6 +60,10 @@ public function refactor(Node $node): MethodCall|StaticCall|null
             return null;
         }
 
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
         if (count($node->getArgs()) < 2) {
             return null;
         }

diff --git a/...y/Rector/MethodCall/AssertEqualsOrAssertSameFloatParameterToSpecificMethodsTypeRector.php b/...y/Rector/MethodCall/AssertEqualsOrAssertSameFloatParameterToSpecificMethodsTypeRector.php
@@ -71,6 +71,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
         $args = $node->getArgs();
 
         $firstValue = $args[0]->value;

diff --git a/rules/CodeQuality/Rector/MethodCall/NarrowIdenticalWithConsecutiveRector.php b/rules/CodeQuality/Rector/MethodCall/NarrowIdenticalWithConsecutiveRector.php
@@ -93,6 +93,10 @@ public function refactor(Node $node): MethodCall|null
             return null;
         }
 
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
         $firstArg = $node->getArgs()[0];
 
         // skip as most likely nested array of unique values

diff --git a/rules/CodeQuality/Rector/MethodCall/SingleWithConsecutiveToWithRector.php b/rules/CodeQuality/Rector/MethodCall/SingleWithConsecutiveToWithRector.php
@@ -87,6 +87,10 @@ public function refactor(Node $node): MethodCall|null
             return null;
         }
 
+        if ($node->isFirstClassCallable()) {
+            return null;
+        }
+
         if (count($node->getArgs()) !== 1) {
             return null;
         }

diff --git a/rules/PHPUnit100/Rector/StmtsAwareInterface/WithConsecutiveRector.php b/rules/PHPUnit100/Rector/StmtsAwareInterface/WithConsecutiveRector.php
@@ -223,6 +223,10 @@ private function matchAndRefactorExpectsMethodCall(Expression $expression): Meth
                 return null;
             }
 
+            if ($node->isFirstClassCallable()) {
+                return null;
+            }
+
             $firstArg = $node->getArgs()[0];
             if (! $firstArg->value instanceof MethodCall && ! $firstArg->value instanceof StaticCall) {
                 return null;