Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCTRINE_DBAL_210 incorrectly renames some Doctrine\DBAL\Types\Type usages #100

Closed
Blacksmoke16 opened this issue May 23, 2022 · 1 comment
Closed

DOCTRINE_DBAL_210 incorrectly renames some Doctrine\DBAL\Types\Type usages #100

Blacksmoke16 opened this issue May 23, 2022 · 1 comment

Comments

@Blacksmoke16
Copy link

Blacksmoke16 commented May 23, 2022 •
edited
Loading

For example, if using custom types:

<?php

\Doctrine\DBAL\Types\Type::addType('money', 'My\Project\Types\MoneyType');

would be updated to:

<?php

\Doctrine\DBAL\Types\Types::addType('money', 'My\Project\Types\MoneyType');

Which is invalid since these methods only exist on the Doctrine\DBAL\Types\Type version.

Introduced in rectorphp/rector#2514.
kick-the-bucket added a commit to kick-the-bucket/rector-doctrine that referenced this issue Jun 10, 2022
@kick-the-bucket
Add tests for DoctrineDBAL210Set to prove rectorphp#100
ec034ee
kick-the-bucket added a commit to kick-the-bucket/rector-doctrine that referenced this issue Jun 10, 2022
@kick-the-bucket
Change DOCTRINE_DBAL_210 set to only change constants. Fixes rectorph…
d2fe38a 
…p#100
@samsonasik
Copy link
Member

fixed at #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samsonasik @Blacksmoke16