Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

0.9.3 grunt cleanup #111

Merged
merged 3 commits into from
May 25, 2013
Merged

Conversation

robdodson
Copy link

I figured it'd be good to just go ahead and open a pull request so you can see my in progress changes and we can discuss them.

robdodson added 3 commits May 24, 2013 22:10
- Also removed composer.lock from .gitignore. I believe this file is intended to be checked in, similar to Gemfile.lock. http://stackoverflow.com/questions/12896780/composer-lock-part-of-the-repository
- Added `frank` template to cut down on long file paths
- Had to add `rename` to coffeescript task because `ext` cuts off at the first period in a filename. So frank.slideshow.coffee becomes frank.js. Bug is here: gruntjs/grunt#750
@robdodson
Copy link
Author

So far I've added matchdep to autoload anything in the node_modules folder starting with grunt-. That captures pretty much all 3rd party tasks except for svgo-grunt (e028fb2).

Next I started focusing on the coffeescript task because I wanted to see if templates and dynamic file objects could improve things (2829aae). I think the templates could start to reduce some of the long file path noise. And the dynamic files object might be a line or two longer than the former arrays but it lets you compile any coffeescript in that folder versus having to create a new path in your Gruntfile every time you add a file. I ran into a snag where grunt's ext option wasn't playing nice with the dynamic file object because it chops off at the first period. So instead of just being able to say ext: '.js' in the coffeescript task it has to use that rename function. This is only to support frank.slideshow.coffee. If that file was renamed frank-slideshow.coffee like its sibling defer-image-load.coffee then we could use ext.

@somerandomdude
Copy link
Collaborator

Oh, this is awesome! Definitely already a huge improvement. Stuff like this shows how much I still have to learn about Grunt. Thanks man!

somerandomdude added a commit that referenced this pull request May 25, 2013
@somerandomdude somerandomdude merged commit 359ee8a into recprog:0.9.3 May 25, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants