Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TD-596 - Add output with correct name for primary_connection_string #348

Merged
merged 2 commits into from
Aug 14, 2023
Merged

TD-596 - Add output with correct name for primary_connection_string #348

merged 2 commits into from
Aug 14, 2023

Conversation

tom-reinders
Copy link
Member

@tom-reinders tom-reinders commented Aug 8, 2023 •
edited
Loading

Changelog:

### Added

- `azure/storage_account_private`: Add output `primary_connection_string` (#348) (ba78e538) (@tom-reinders)
- `azure/storage_account_public`: Add output `primary_connection_string` (#348) (ba78e538) (@tom-reinders)

@tom-reinders tom-reinders added this to the v3.8.0 milestone Aug 8, 2023
@tom-reinders tom-reinders marked this pull request as ready for review August 8, 2023 13:19
@tom-reinders tom-reinders requested a review from a team as a code owner August 8, 2023 13:19
@tom-reinders tom-reinders self-assigned this Aug 8, 2023
bartwesselink
bartwesselink approved these changes Aug 14, 2023
View reviewed changes
Copy link

@bartwesselink bartwesselink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tom-reinders kan je die daar onder deprecated maken?

@tom-reinders
Copy link
Member Author

@tom-reinders kan je die daar onder deprecated maken?

@bartwesselink

Nope, hashicorp/terraform#18381

I have added comments and descriptions to the deprecated outputs, but i can't make them really deprecated, will fix that if terraform fixes this before the next major version.

@bartwesselink
Copy link

@tom-reinders oké, maar kunnen wij deze niet vast klaarzetten / verwijderen in onze nieuwe major versie?

@tom-reinders
Copy link
Member Author

@bartwesselink Zal ik doen.

@tom-reinders tom-reinders merged commit 96cb8e4 into develop Aug 14, 2023
@tom-reinders tom-reinders deleted the feature/TD-596_add_output_with_correct_name_for_connection_string branch August 14, 2023 11:17
@tom-reinders tom-reinders mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartwesselink bartwesselink bartwesselink approved these changes

Assignees

@tom-reinders tom-reinders

Labels
None yet
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-reinders @bartwesselink