Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Batch support on ComfyUI #13

Closed
Tirshea opened this issue Oct 26, 2023 · 5 comments
Closed

[FEATURE REQUEST] - Batch support on ComfyUI #13

Tirshea opened this issue Oct 26, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Tirshea
Copy link

Tirshea commented Oct 26, 2023

Summary

First, thank you for the node suite. I've been playing with it the last few days and it screams "must-have batch tool for upscaling workflow from low-quality rushes/seed images".

The abilty to load images with their metadata is awesome, especially when - like me - you use wildcards a lot.

But when we design an upscaling workflow, we most likely want it to support batch loading.

I tried the obvious way with "convert image to input" on the reader but I couldn't find any node able to link to this "image" input.

image

Basic Example

Abillity to connect image loaders to SD_Prompt_Read node.

Reference Issues.

No response

@Tirshea Tirshea added the question Further information is requested label Oct 26, 2023
@receyuki
Copy link
Owner

Please submit issues related to the ComfyUI node version in the node version repo next time, thx.

Actually, someone has already made exactly the same request to me before. The reason why the image loader cannot connect with the reader is that the image loader outputs the image itself, which is a bunch of pixels, and does not include any metadata. So even if they could connect, the reader wouldn’t be able to read anything.

Of course, I’m very interested in the batch loading you mentioned. If possible, please post your batch loading workflow here. Since the reader itself is an image loader, perhaps features suported by other image loaders could also be implemented on the prompt reader.

@Tirshea
Copy link
Author

Tirshea commented Oct 27, 2023

Here are two examples I use when I need to process a series of images or a random one inside a folder :
image

It is just a basic ImageLoader, but we play with the index INT.

@receyuki
Copy link
Owner

This feature seems to be feasible, I'll consider it.

@receyuki receyuki added enhancement New feature or request and removed question Further information is requested labels Oct 30, 2023
@receyuki receyuki transferred this issue from receyuki/stable-diffusion-prompt-reader Oct 30, 2023
@PSVinrael
Copy link

Just a +1 to say this node is exactly what I've been looking for to finish an A1111 based 1.5 to SDXL Upscale Workflow and literally the only thing missing is batch processing, would be perfect in that case.

@receyuki
Copy link
Owner

@Tirshea @PSVinrael
The batch processing feature is now ready! Please update to the latest version.

Simply connect the Batch Loader to the Prompt Reader. When you set the image_load_limit to 1, you’ll be able to use the Batch Loader just like the LoadImageInFolder you mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants