fix: improve typing

arguebuf/dump/_dump_dict.py

@@ -20,4 +20,4 @@ def dump_dict(graph: Graph, config: Config = DefaultConfig) -> dict[str, t.Any]:
     elif config.format == Format.XAIF:
         return t.cast(dict[str, t.Any], dump_xaif(graph))
 
-    return MessageToDict(dump_protobuf(graph), including_default_value_fields=False)
+    return MessageToDict(dump_protobuf(graph), including_default_value_fields=False)  # type: ignore

arguebuf/load/_load_casebase.py

@@ -69,7 +69,10 @@ def __init__(self, name: str, cases: str | None = None, **kwargs: str):
         for key, value in kwargs.items():
             self.kwargs[key] = re.compile(value)
 
-    def __eq__(self, other: FilesystemFilter) -> bool:
+    def __eq__(self, other) -> bool:
+        if not isinstance(other, FilesystemFilter):
+            return False
+
         return self.kwargs == other.kwargs and self >= other
 
     def __ge__(self, other: FilesystemFilter) -> bool:

arguebuf/model/edge.py

@@ -1,5 +1,4 @@
 import logging
-import typing as t
 
 from arguebuf.model import utils
 from arguebuf.model.metadata import Metadata
@@ -59,8 +58,8 @@ def __init__(
     def __post_init__(self):
         pass
 
-    def __eq__(self, other: t.Optional["Edge"]) -> bool:
-        if other is None:
+    def __eq__(self, other) -> bool:
+        if other is None or not isinstance(other, Edge):
             return False
 
         return (

arguebuf/model/metadata.py

@@ -6,7 +6,6 @@
 class Metadata:
     created: pendulum.DateTime
     updated: pendulum.DateTime
-    # _analyst: t.Optional[Analyst] = None
 
     def __init__(
         self,
@@ -18,9 +17,5 @@ def __init__(
         self.created = created or now
         self.updated = updated or now
 
-    # @property
-    # def analyst(self) -> t.Optional[Analyst]:
-    #     return self._analyst
-
     def update(self) -> None:
         self.updated = pendulum.now()

arguebuf/model/node.py

@@ -70,11 +70,11 @@ def __init__(
 
         self.__post_init__()
 
-    def __post_init__(self):
+    def __post_init__(self):  # noqa: B027
         pass
 
-    def __eq__(self, other: "AbstractNode") -> bool:
-        if other is None:
+    def __eq__(self, other) -> bool:
+        if other is None or not isinstance(other, AbstractNode):
             return False
 
         return self.id == other.id
@@ -214,5 +214,5 @@ def color(self, major_claim: bool, monochrome: bool) -> Color:
         return scheme2color[type(self.scheme)] if self.scheme else Color(bg="#009688")
 
 
-AtomOrSchemeNode = t.Union[AtomNode, SchemeNode]
+AtomOrSchemeNode = AtomNode | SchemeNode
 NodeType = t.TypeVar("NodeType", AtomNode, SchemeNode, AbstractNode)

arguebuf/model/scheme.py

@@ -1,4 +1,3 @@
-import typing as t
 from enum import Enum
 
 from arg_services.graph.v1 import graph_pb2
@@ -116,7 +115,7 @@ class Rephrase(str, Enum):
     DEFAULT = "Default"
 
 
-Scheme = t.Union[Support, Attack, Rephrase, Preference]
+Scheme = Support | Attack | Rephrase | Preference
 
 support2protobuf = {
     item: graph_pb2.Support.Value(f"SUPPORT_{item.name}") for item in Support

arguebuf/model/utils.py

@@ -132,7 +132,7 @@ def __len__(self) -> int:
     def __getitem__(self, key: _T) -> _U:
         return self._store.__getitem__(key)
 
-    def __contains__(self, key: _T) -> bool:
+    def __contains__(self, key) -> bool:
         return self._store.__contains__(key)
 
     def __iter__(self) -> t.Iterator:

arguebuf/schemas/graphviz.py

@@ -1,9 +1,9 @@
-import typing as t
 from enum import Enum
+from typing import Any
 
 from graphviz import Digraph
 
-GraphvizGraph = t.Union[Digraph, t.Any]
+GraphvizGraph = Digraph | Any
 
 
 class EdgeStyle(str, Enum):