This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Add pagination to IAMUser and IAMGroup modules #985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #981, the IAMUser and IAMGroup modules did not paginate their queries and thus only fetched and removed the first 100 of each resource type.
This PR adds pagination support to ensure AWS Nuke will clean up more than the default 100 limit.
Fixes #981
Testing
Create a set of resources with the following:
Run AWS Nuke using the
IAMUser
andIAMGroup
resource types. It should print out that it found 150 of each type and proceed to remove them.