This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Add all ACM Certificate key types to query #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only lists RSA_1024 and RSA_2048.
der-eismann
approved these changes
Mar 17, 2023
svenwltr
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
ListCertificatesmethod only listsRSA_2048key types. This leaves many other types unlisted and unhandled by AWS Nuke.Ref: https://docs.aws.amazon.com/sdk-for-go/api/service/acm/#ACM.ListCertificates
This PR adds all supported types to the query.
Testing performed