Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Draft: Add Lightsail resources #943

Closed
wants to merge 2 commits into from

Conversation

danarbaugh
Copy link

@danarbaugh danarbaugh commented Feb 23, 2023

This adds additional Lightsail resources for cleanup via the Cloud Control API. This mimics the approach taken in #937 for adding ECR resources. Following this change, the output for go run ./dev/list-cloudcontrol would be the following:

$ go run ./dev/list-cloudcontrol
... # Snipped irrelevant resources from output
AWS::Lightsail::Alarm                                  is only covered by AWS::Lightsail::Alarm
AWS::Lightsail::Bucket                                 is only covered by AWS::Lightsail::Bucket
AWS::Lightsail::Certificate                            is only covered by AWS::Lightsail::Certificate
AWS::Lightsail::Container                              is only covered by AWS::Lightsail::Container
AWS::Lightsail::Database                               is only covered by AWS::Lightsail::Database
AWS::Lightsail::Disk                                   is also covered by LightsailDisk
AWS::Lightsail::Distribution                           is only covered by AWS::Lightsail::Distribution
AWS::Lightsail::Instance                               is also covered by LightsailInstance
AWS::Lightsail::LoadBalancer                           is also covered by LightsailLoadBalancer
AWS::Lightsail::LoadBalancerTlsCertificate             is only covered by AWS::Lightsail::LoadBalancerTlsCertificate
AWS::Lightsail::StaticIp                               is also covered by LightsailStaticIP
...

@danarbaugh
Copy link
Author

I had originally opened this PR with a slight misunderstanding of how Cloud Control configuration worked and how AWS_NUKE_CLOUD_CONTROL_TYPES could be used. Closing this PR given it is essentially noop.

@danarbaugh danarbaugh closed this May 24, 2023
@danarbaugh danarbaugh deleted the lightsail-resources branch May 24, 2023 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant