Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

adds support for s3 object versions #76

Merged
merged 1 commit into from
Feb 27, 2018
Merged

adds support for s3 object versions #76

merged 1 commit into from
Feb 27, 2018

Conversation

svenwltr
Copy link
Member

@svenwltr svenwltr commented Feb 25, 2018 •
edited
Loading

Closes #62 #64 #67

I tried to rebase or merge #67, but I horribly failed. Therefore I had to manually apply the patch. Changes from #67:

  • uses the new resources API
  • doesn't print and filter the version ID for latest object
  • actually deletes the objects

@rebuy-de/prp-aws-nuke Please review.

@svenwltr svenwltr self-assigned this Feb 25, 2018
@svenwltr svenwltr mentioned this pull request Feb 25, 2018
Closed
@svenwltr svenwltr requested a review from bethge February 27, 2018 08:36
bethge
bethge approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@bethge bethge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svenwltr svenwltr merged commit 75fadd5 into master Feb 27, 2018
@svenwltr svenwltr deleted the support-object-versions branch February 27, 2018 14:49
@svenwltr svenwltr added the kind/enhancement New core feature or improvement of existing ones. label Mar 29, 2018
@svenwltr svenwltr mentioned this pull request Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bethge bethge bethge approved these changes

@bjoernhaeuser bjoernhaeuser bjoernhaeuser approved these changes

@octopusx octopusx octopusx approved these changes

Assignees

@svenwltr svenwltr

Labels
kind/enhancement New core feature or improvement of existing ones.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svenwltr @bethge @bjoernhaeuser @octopusx