This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Add IAMUserPolicy resource #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenwltr
previously approved these changes
Jan 10, 2018
bethge
reviewed
Jan 10, 2018
| return resources, nil | ||
| } | ||
|
|
||
| func (e *IAMUserPolicy) Remove() error { |
There was a problem hiding this comment.
its named like this in other places as well. for example:
aws-nuke/resources/iam-users.go
Line 36 in 2d9b2f8
i'm also not a big fan of those ambiguous one letter variable names but i felt like following the style of the other resources out-weights that urge in that case.
if we adapt to having proper variable naming here, then i'd vote for doing it in all the places at once in a separate pull request.
There was a problem hiding this comment.
svenwltr
force-pushed
the
refactor-listers
branch
from
2db35a1 to
097be85
Compare
stephanlindauer
force-pushed
the
aws_user_policy
branch
from
2d9b2f8 to
a08293c
Compare
svenwltr
approved these changes
Jan 10, 2018
bethge
approved these changes
Jan 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @rebuy-de/prp-aws-nuke