Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

add more warnings to the readme #291

Merged
merged 1 commit into from
Nov 6, 2018
Merged

add more warnings to the readme #291

merged 1 commit into from
Nov 6, 2018

Conversation

svenwltr
Copy link
Member

@svenwltr svenwltr commented Nov 6, 2018

There can never be enough warnings about this. Please take a look at the wording.

Also I rephrased the description, because the term nuke is not really descriptive.

@rebuy-de/prp-aws-nuke Please review.

@svenwltr svenwltr self-assigned this Nov 6, 2018
Copy link
Contributor

@stephanlindauer stephanlindauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😨

README.md Outdated
@@ -15,6 +15,9 @@ a Pull Request or to create an [Issue](https://github.com/rebuy-de/aws-nuke/issu
Be aware that *aws-nuke* is a very destructive tool, hence you have to be very
careful while using it. Otherwise you might delete production data.

**We strongly advice you to not run this application on any AWS account, were
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*where

README.md Outdated
@@ -284,6 +287,12 @@ namespace and might be hard to recreate. Currently the filtering is based on
the resource identifier. The identifier will be printed as the first step of
*aws-nuke* (eg `i-01b489457a60298dd` for an EC2 instance).

**Note: Even with filters you should not run aws-nuke on any AWS account, were
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*where

@svenwltr svenwltr merged commit 22e64b4 into master Nov 6, 2018
@svenwltr svenwltr deleted the update-readme branch November 6, 2018 13:19
@svenwltr svenwltr added the kind/documentation The documentation needs an update. label Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/documentation The documentation needs an update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants