This repository was archived by the owner on Oct 15, 2024. It is now read-only.
fix MFA auth #257
Merged
fix MFA auth #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernhaeuser
approved these changes
Aug 31, 2018
stephanlindauer
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MFA auth by adding
AssumeRoleTokenProviderto the session options.Since aws-nuke created a new session for each region and two for initialization, it asked quite often for the MFA token. Furthermore it looks like it does not allow to use the same token twice, which means one has to wait a minute between each session creation.
Fortunately is is possible to copy a session and change some parameters. So I refactored it that we have a singe root session, which gets copied and adjusted for each region.
@rebuy-de/prp-aws-nuke Please review.