make resource ID optional

[svenwltr]

Make resource IDs optional (ie IDs from String() function). New resources should use the property feature instead.

Making legacy to avoid awkward resource IDs like this in wafregional-ip-set-ips.go:

return fmt.Sprintf("%s -> %s:%s", *r.ipSetid, *r.descriptor.Type, *r.descriptor.Value)

Describing waf.FieldToMatch in a single string would be even more complex.

@rebuy-de/prp-aws-nuke Please review.

[tomvachon]

Do we need to refactor for this? Seems like a big change. I’d almost rather wait until the go sdk v2 since we will have to refactor everything anyways

…

On Tue, Jun 26, 2018 at 5:55 AM Sven Walter ***@***.***> wrote: Make resource IDs optional (ie IDs from String() function). New resources should use the property feature instead. Making legacy to avoid awkward resource IDs like this in wafregional-ip-set-ips.go: return fmt.Sprintf("%s -> %s:%s", *r.ipSetid, *r.descriptor.Type, *r.descriptor.Value) Describing waf.FieldToMatch <https://godoc.org/github.com/aws/aws-sdk-go/service/waf#FieldToMatch> in a single string would be even more complex. @rebuy-de/prp-aws-nuke <https://github.com/orgs/rebuy-de/teams/prp-aws-nuke> Please review. ------------------------------ You can view, comment on, or merge this pull request online at: #217 Commit Summary - make resource ID optional File Changes - *M* cmd/log.go <https://github.com/rebuy-de/aws-nuke/pull/217/files#diff-0> (8) - *M* cmd/nuke.go <https://github.com/rebuy-de/aws-nuke/pull/217/files#diff-1> (2) - *M* cmd/queue.go <https://github.com/rebuy-de/aws-nuke/pull/217/files#diff-2> (6) - *M* resources/dynamodb-items.go <https://github.com/rebuy-de/aws-nuke/pull/217/files#diff-3> (18) - *M* resources/interface.go <https://github.com/rebuy-de/aws-nuke/pull/217/files#diff-4> (8) Patch Links: - https://github.com/rebuy-de/aws-nuke/pull/217.patch - https://github.com/rebuy-de/aws-nuke/pull/217.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#217>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUQRd0otAnVMw2kEVeOySJ2r4WO3OBuks5uAgUPgaJpZM4U3nS0> .

[svenwltr]

@tomvachon We do not have to refactor every resource, now. Currently, both methods are possible and there is no need to touch the old resources. I would say we put this on the aws-nuke v3 roadmap.

[tomvachon]

Agreed. Any clue how close v2 is for the sdk? I don’t track it closely

…

On Tue, Jun 26, 2018 at 7:09 AM Sven Walter ***@***.***> wrote: @tomvachon <https://github.com/tomvachon> We do not have to refactor every resource, now. Currently, both methods are possible and there is no need to touch the old resources. I would say we put this on the *aws-nuke* v3 roadmap. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#217 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUQRUO2-uNvv7KXDSq0JgRTNuUuE4wYks5uAhZMgaJpZM4U3nS0> .

[svenwltr]

Any clue how close v2 is for the sdk? I don’t track it closely

No, I did not find any roadmap for v2.

[svenwltr]

I had to update the PR, since the resource comparison did not work with the previous one. I am not very satisfied with this solution, but it works.