[SYCL][Graph] in-order queue barrier fix #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for intel#13066 The special case for using barriers on an in-order queue is that the last event/node submitted to the queue is used as an event for the barrier to depend on. Looking at the last command submitted to the queue isn't correct for a graph, because previous commands submitted to a graph could have been added explicitly or from recording another queue. Therefore, there is not guaranteed that the last command submitted by the in-order queue is correct dependency for the barrier node in the graph.
EwanC
force-pushed
the
ewan/in_order_barrier_fix
branch
from
27a2a32
to
04f474c
Compare
|
Going straight to upstream due to urgency of this bug fix intel#13193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for intel#13066
The special case for using barriers on an in-order queue is that the last event/node submitted to the queue is used as an event for the barrier to depend on.
Looking at the last command submitted to the queue isn't correct for a graph, because previous commands submitted to a graph could have been added explicitly or from recording another queue. Therefore, there is not guaranteed that the last command submitted by the in-order queue is correct dependency for the barrier node in the graph.