-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Add tests checking event status querying #244
[SYCL][Graph] Add tests checking event status querying #244
Conversation
577e84c
to
57606fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one very minor comment
Checks the info::event_command_status on an event returned from graph submission. Closes Issue: #95
57606fc
to
57858ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these tests are an useful addition. Do we only want to verify the event info though? Couldn't we call a host kernel that waits a short time instead? This would simplify the tests and make the expected two states of the event reproducible.
This PR addresses Issue #95. Using a host_task is indeed a good idea, but unfortunately this feature is not supported by the graph implementation at the moment. |
I am okay with merging this as it is. We might want to add an issue though to make these tests reproducible and simplify them in the future. E.g., a long counting loop could do the trick as well. |
Checks the info::event_command_status on an event returned from graph submission.
Closes Issue: #95