[SYCL] Stop USM arguments creating edges in the explicit API #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead it is buffer accessors that should be used for edge detection Fixes graph-explicit-node-ordering which is currently creating incorrect extra edges
EwanC
commented
Mar 17, 2023
EwanC
changed the title
reble
reviewed
Mar 20, 2023
Bensuo
approved these changes
Mar 20, 2023
In the graphs tests guard sycl::reductions in kernel nodes with macro `TEST_GRAPH_REDUCTIONS`. This is defaulted to undefined while the feature is broken, but can be enabled by setting `-DTEST_GRAPH_REDUCTIONS=1` during compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead it is buffer accessors that should be used for edge detection
Fixes graph-explicit-node-ordering which is currently creating incorrect extra edges