-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add children
property to Edges/Port components
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amcdnl I've started working on this, I hope you see how useful children
can be. It's not mergeable yet (haven't done Port) but it's a good start and I'll implement the Port similarly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall - just a few nits
@amcdnl Could you release a new version please? I'd like to use this. 😄 |
Oh crap - I forgot! doing now! |
is there any documentation on how to use this? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using
children
isn't currently possible for Edge/Port components.Issue Number:
children
property (similar to Nodes) #67What is the new behavior?
Using
children
is now possible for Edge/Port components.Does this PR introduce a breaking change?
Other information
New capabilities:
children
to display custom React components at the center of an edge.children
to display custom React components close to a port.Used by Vadorequest/rwa-faunadb-reaflow-nextjs-magic#4 to display the following:
Depends on #69 for adding component tests.
Fixes #67