Migrate snapshot to cram #767
Conversation
ppx/dune
Outdated
| (name standalone) | ||
| (modules standalone) | ||
| (package reason-react-ppx) | ||
| (public_name reason-react-ppx.standalone) |
There was a problem hiding this comment.
Is there any reason to make this public? I think the ppx will always be consumed as a library.
There was a problem hiding this comment.
It can be useful to run the ppx transformation as an executable. I'm in favor of this one.
I'd name it to a better name though. I think it can even be called reason-react-ppx. it'll be installed in bin/reason-react-ppx.
There was a problem hiding this comment.
I didn't know was possible the same name as the lib
ppx/test/functor.t/run.t
Outdated
| @@ -0,0 +1,20 @@ | |||
| $ ../ppx.sh input.re | |||
There was a problem hiding this comment.
Why sometimes ppx_with_refmt is used and some other times just ppx?
…-ppx-tests-to-cram-tests * 'main' of github.com:/reasonml/reason-react: Allow memoCustomCompareProps on ppx (#766)
…l/reason-react into Migrate-ppx-tests-to-cram-tests * 'Migrate-ppx-tests-to-cram-tests' of github.com:/reasonml/reason-react: Rename standalone as 'reason-react-ppx'
* main: Migrate snapshot to cram (#767)
There was a problem hiding this comment.
I just noticed one downside of this rearrangement is that now merlin tests are mixed up with the other ppx tests. I will open a PR to put them back together because the tests are quite different and it was nice to have them grouped together.
As usual, a migration to cram tests