Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add React.float and React.int #420

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

utkarshkukreti
Copy link
Contributor

Plain JS numbers are valid React elements. Without these two functions you have to use either string_of_* or Js.*.toString which generates unnecessary code.

Copy link
Contributor

@connorbrathwaite connorbrathwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyvetter rickyvetter merged commit ee9df7b into reasonml:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants