feat(k8s): support custom namespaces for Dask resources #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 17 17
Lines 1864 1864
=======================================
Hits 1417 1417
Misses 447 447
|
Alputer
changed the title
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 15, 2025
Alputer
force-pushed
the
dask-custom-namespace
branch
from
0b6829a to
b18801c
Compare
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 16, 2025
Alputer
force-pushed
the
dask-custom-namespace
branch
from
b18801c to
ea89a32
Compare
tiborsimko
reviewed
Jan 16, 2025
| @@ -759,7 +759,7 @@ def _create_job_spec( | |||
| job_controller_container.env.append( | |||
| { | |||
| "name": "DASK_SCHEDULER_URI", | |||
| "value": f"reana-run-dask-{self.workflow.id_}-scheduler.default.svc.cluster.local:8786", | |||
| "value": f"reana-run-dask-{self.workflow.id_}-scheduler.{REANA_RUNTIME_KUBERNETES_NAMESPACE}.svc.cluster.local:8786", | |||
There was a problem hiding this comment.
todo: Please use capital Dask in the commit message headline. (Useful for the release notes.)
tiborsimko
changed the title
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Jan 16, 2025
Alputer
force-pushed
the
dask-custom-namespace
branch
from
ea89a32 to
87e88c0
Compare
Alputer
force-pushed
the
dask-custom-namespace
branch
from
87e88c0 to
fbab460
Compare
tiborsimko
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawn and delete dask resources inside the kubernetes namespace used by the REANA cluster.
Closes #619