-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rest): detect session status from the pod state #611
fix(rest): detect session status from the pod state #611
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 76.59% 76.01% -0.58%
==========================================
Files 17 17
Lines 1846 1864 +18
==========================================
+ Hits 1414 1417 +3
- Misses 432 447 +15
|
a50932b
to
49cf295
Compare
49cf295
to
f88c09a
Compare
reana_workflow_controller/k8s.py
Outdated
@@ -479,3 +479,16 @@ def delete_dask_dashboard_ingress(cluster_name, workflow_id): | |||
plural="middlewares", | |||
name=f"replacepath-{workflow_id}", | |||
) | |||
|
|||
|
|||
def check_pod_status_by_prefix(pod_name_prefix, namespace="default"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "default" namespace value, we could use the one we have in r-commons
, i.e. REANA_RUNTIME_KUBERNETES_NAMESPACE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message cosmetics: instead of "get the session status from..." we could say "detect session status from..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit scope cosmetics: since the commit touches component named k8s.py
or rest/workflows.py
, we should rather use fix(rest)
instead of fix(sessions)
. The scope is usually named after the component or the subcomponent of the source code that the commit touches; it is not named after the functionality. Although we have not been respecting this conventional commits semantics so for so strictly everywhere 😉
f88c09a
to
907459b
Compare
Closes reanahub/reana-ui#408