Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow customising ingress hosts #587

Closed
tiborsimko opened this issue Jun 13, 2024 · 0 comments · Fixed by #588 or reanahub/reana#804
Closed

config: allow customising ingress hosts #587

tiborsimko opened this issue Jun 13, 2024 · 0 comments · Fixed by #588 or reanahub/reana#804
Assignees

Comments

@tiborsimko
Copy link
Member

For the SSL-RIVER deployment, the opening of notebooks necessitates the creation of ingresses with a dedicated host. (Currently we use * which is not working.)

Basically we need to allow the following:

$ kubectl get ingresses
NAME                                                     CLASS           HOSTS         ADDRESS   PORTS     AGE
reana-ingress                                            reana-traefik   *                       80, 443   9d
reana-run-session-e32d22d2-35eb-41c9-86ae-cd39ef39596d   reana-traefik   foo.bar.com             80        5d21h

The above test was performed by:

$ kubectl edit ingress reana-run-session-e32d22d2-35eb-41c9-86ae-cd39ef39596d 
$ kubectl get ingress reana-run-session-e32d22d2-35eb-41c9-86ae-cd39ef39596d -o yaml
...
spec:
  ingressClassName: reana-traefik
  rules:
  - host: foo.bar.com
    http:
      paths:
      - backend:

The goal of this issue is to introduce a new configuration variable REANA_INGRESS_HOST, alongside existing variables REANA_INGRESS_ANNOTATIONS and REANA_INGRESS_CLASS_NAME, that would allow to customize the host part of the ingress rules.

Alputer added a commit to Alputer/reana-workflow-controller that referenced this issue Jun 18, 2024
@mdonadoni mdonadoni added this to 0.9.4 Jun 27, 2024
@mdonadoni mdonadoni moved this to Done in 0.9.4 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
3 participants