Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(master): merge maint-0.9 #715

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

chore(master): merge maint-0.9 #715

wants to merge 16 commits into from

Conversation

tiborsimko
Copy link
Member

tiborsimko and others added 15 commits May 15, 2024 10:22
@tiborsimko
fix(reana-admin): respect service domain when cleaning sessions (rean…
ede882d 
…ahub#687)

Removes hard-coded infrastructure component host name domain
"svc.local.cluster" during interactive session clean-up procedures,
since this assumption is not really necessary and would not work under
some deployment scenarios, such as on SSL-RIVER.

Closes reanahub/reana-commons#457
@mdonadoni
fix(start): validate endpoint parameters (reanahub#689)
d2d3673 
Closes reanahub/reana-client#718
@mdonadoni
fix(get_workflow_specification): avoid returning null parameters (rea…
46633d6 
…nahub#689)

Closes reanahub/reana-client#718
@mdonadoni
ci(commitlint): improve checking of merge commits (reanahub#689)
69f45fc
@mdonadoni
fix(set_workflow_status): publish workflows to submission queue (rean…
6e35bd7 
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
@tiborsimko
chore(docker): pin setuptools 70 (reanahub#700)
7356b28 
Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu
20.04 LTS based environments. (New versions of `setuptools` are not
compatible.)

Note that this fix is necessary only for the `maint-0.9` branches and
the REANA 0.9 release series. In `master` we have switched to Ubuntu
24.04 LTS based environments and Python 3.12 and no pinning is necessary
there.
@mdonadoni
fix(config): read secret key from env (reanahub#713)
6ee6422 
Make sure the secret key is propagated to the Flask app, instead of
incorrectly using the default one.
@mdonadoni
feat(config): support password-protected redis (reanahub#713)
a2aad8a 
REANA can now connect to password-protected Redis instances.
@mdonadoni
fix(config): do not set DEBUG programmatically (reanahub#713)
c98cbc1 
The `DEBUG` configuration value is not set programmatically anymore, as
Flask documentation warns that it might behave unexpectedly if set in
code. `DEBUG` can still be customised via the `FLASK_DEBUG` environment
variable.
@mdonadoni
feat(config): make PROXYFIX_CONFIG customisable (reanahub#713)
5b6c276 
Allow customisation of the `PROXYFIX_CONFIG` configuration value, to
support deployments where REANA is served behind multiple proxies.
@mdonadoni
feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713
1919358 
)

Allow customisation of the `APP_DEFAULT_SECURE_HEADERS_ configuration
value, to be able to configure Flask-Talisman's security mechanisms.
@mdonadoni
feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713)
8c01d51 
Allow enabling and disabling the `X-User-ID` and `X-User-Session`
headers that were always set on HTTP responses. These are useful only
for debug purposes, and they are not needed otherwise.
@mdonadoni
feat(ext): improve error message for db decryption error (reanahub#713)
bbab1bf
@mdonadoni
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714
94fbf77 
)
@github-actions @mdonadoni
chore(maint-0.9): release 0.9.4
29f9c7b
@tiborsimko tiborsimko self-assigned this Dec 4, 2024
tiborsimko added a commit to tiborsimko/reana-server that referenced this pull request Dec 4, 2024
@tiborsimko
chore(master): merge maint-0.9 (reanahub#715)
0b3a929 
chore(maint-0.9): release 0.9.4 (reanahub#666)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714)
feat(ext): improve error message for db decryption error (reanahub#713)
feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713)
feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713)
feat(config): make PROXYFIX_CONFIG customisable (reanahub#713)
fix(config): do not set DEBUG programmatically (reanahub#713)
feat(config): support password-protected redis (reanahub#713)
fix(config): read secret key from env (reanahub#713)
chore(docker): pin setuptools 70 (reanahub#700)
fix(set_workflow_status): publish workflows to submission queue (reanahub#691)
ci(commitlint): improve checking of merge commits (reanahub#689)
fix(get_workflow_specification): avoid returning null parameters (reanahub#689)
fix(start): validate endpoint parameters (reanahub#689)
fix(reana-admin): respect service domain when cleaning sessions (reanahub#687)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
@tiborsimko
chore(master): merge maint-0.9 (reanahub#715)
e54b414 
chore(maint-0.9): release 0.9.4 (reanahub#666)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714)
feat(ext): improve error message for db decryption error (reanahub#713)
feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713)
feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713)
feat(config): make PROXYFIX_CONFIG customisable (reanahub#713)
fix(config): do not set DEBUG programmatically (reanahub#713)
feat(config): support password-protected redis (reanahub#713)
fix(config): read secret key from env (reanahub#713)
chore(docker): pin setuptools 70 (reanahub#700)
fix(set_workflow_status): publish workflows to submission queue (reanahub#691)
ci(commitlint): improve checking of merge commits (reanahub#689)
fix(get_workflow_specification): avoid returning null parameters (reanahub#689)
fix(start): validate endpoint parameters (reanahub#689)
fix(reana-admin): respect service domain when cleaning sessions (reanahub#687)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 60.31746% with 25 lines in your changes missing coverage. Please review.

Project coverage is 60.03%. Comparing base (999d716) to head (e54b414).

Files with missing lines Patch % Lines
reana_server/rest/workflows.py 60.00% 20 Missing ⚠️
reana_server/ext.py 0.00% 4 Missing ⚠️
reana_server/config.py 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   60.22%   60.03%   -0.20%     
==========================================
  Files          32       32              
  Lines        3570     3588      +18     
==========================================
+ Hits         2150     2154       +4     
- Misses       1420     1434      +14
Files with missing lines Coverage Δ
reana_server/factory.py 100.00% <ø> (ø)
reana_server/reana_admin/cli.py 51.69% <ø> (ø)
reana_server/version.py 100.00% <ø> (ø)
reana_server/config.py 84.45% <88.88%> (-0.21%) ⬇️
reana_server/ext.py 0.00% <0.00%> (ø)
reana_server/rest/workflows.py 50.46% <60.00%> (-0.68%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tiborsimko tiborsimko

Labels
None yet
Projects
0.95.0
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiborsimko @mdonadoni