Add os_type label to enable/disable based on Sys.os_type
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures are all 5.1 related, but we just merged your other PR adding support for 5.1. |
polytypic
force-pushed
the
enable-by-os_type
branch
from
88dfc58
to
b160aca
Compare
|
I rebased the PR. It would be great to get a new release of mdx soon. Eio could use this feature and OCaml 5.1 has been released, so having the 5.1 fix would be really nice. |
tmattio
added a commit
to tmattio/opam-repository
that referenced
this pull request
Sep 27, 2023
CHANGES: #### Added - Add `os_type` label to enable/disable based on `Sys.os_type` (realworldocaml/mdx#433, @polytypic) - Make MDX compatible with OCaml 5.1 (realworldocaml/mdx#435, @polytypic and @kit-ty-kate) #### Changed - Vendored the odoc-parser library, removing the need to have it as a dependency. (realworldocaml/mdx#430, @jonludlam)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: #### Added - Add `os_type` label to enable/disable based on `Sys.os_type` (realworldocaml/mdx#433, @polytypic) - Make MDX compatible with OCaml 5.1 (realworldocaml/mdx#435, @polytypic and @kit-ty-kate) #### Changed - Vendored the odoc-parser library, removing the need to have it as a dependency. (realworldocaml/mdx#430, @jonludlam)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to skip blocks by comparing against
Sys.os_type.The desire to have something like this arose when working to allow Eio's MDX based tests to run on Windows and I'm using this feature there.
Also related is the issue that proposes a more general ability to skip blocks. The feature that this proposes is less ambitious (less general) and very similar to the existing OCaml
versionconstraint supported by MDX and the implementation follows the same pattern.