fix Attempt to read property "name" on null error

realodix · Jun 10, 2024 · 304352f · 304352f
1 parent 2342c34
commit 304352f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/app/Livewire/Table/BaseUrlTable.php b/app/Livewire/Table/BaseUrlTable.php
@@ -59,7 +59,7 @@ public function fields(): PowerGridFields
     {
         return PowerGrid::fields()
             ->add('author', function (Url $url) {
-                $author = $url->author->name ?? 'Guest';
+                $author = $url->author->name;
 
                 return view('components.table.author', ['name' => $author])
                     ->render();

diff --git a/app/Models/Url.php b/app/Models/Url.php
@@ -71,7 +71,10 @@ protected function casts(): array
      */
     public function author()
     {
-        return $this->belongsTo(User::class, 'user_id');
+        return $this->belongsTo(User::class, 'user_id')
+            ->withDefault([
+                'name' => 'Guest Author',
+            ]);
     }
 
     /**

diff --git a/tests/Feature/AuthPage/UrlListGuestUserTest.php b/tests/Feature/AuthPage/UrlListGuestUserTest.php
@@ -10,13 +10,15 @@
 #[PHPUnit\Group('link-page')]
 class UrlListGuestUserTest extends TestCase
 {
+    private $url;
+
     protected function setUp(): void
     {
         parent::setUp();
 
         // This must be created, to ensure `$url->author->name` does not raise
         // an error.
-        Url::factory()->create(['user_id' => Url::GUEST_ID]);
+        $this->url = Url::factory()->create(['user_id' => Url::GUEST_ID]);
     }
 
     #[PHPUnit\Test]
@@ -37,4 +39,13 @@ public function basicUsersCantAccessPage(): void
             ->get(route('dashboard.allurl.u-guest'));
         $response->assertForbidden();
     }
+
+    #[PHPUnit\Test]
+    public function adminUserCanAccessEditUrlPage(): void
+    {
+        $response = $this->actingAs($this->adminUser())
+            ->get(route('dboard.url.edit.show', $this->url->keyword));
+
+        $response->assertOk();
+    }
 }