Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron and deleted spectron + tests #1505

Merged
merged 2 commits into from
May 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions docs/DEPENDENCIES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@

This document will describe known limitations on the dependencies, specifically why some of the packages are not upgraded to the latest current versions:

## Electron (and spectron)

We're on Electron v11 and consequently spectron v13.

Upgrading introduce a couple of breaking changes that require attention:
- [v12 breaking changes](https://www.electronjs.org/releases/stable?version=12&page=3#breaking-changes-1200)
- [v13 breaking changes](https://www.electronjs.org/releases/stable?version=13&page=2#breaking-changes-1300)

## React & React DOM

We're keeping the `react` and `react-dom` packages on v17 until `react-virtualized` gets released with support for React v18: https://github.com/bvaughn/react-virtualized/issues/1746
Loading