Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object level permission when filtered or sorted #1180

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Object level permission when filtered or sorted #1180

merged 2 commits into from
Sep 27, 2019

Conversation

kraenhansen
Copy link
Member

This fixes #1112 by passing the filtered and sorted results to the ObjectPermissionSidebar component and using this instead of the focus.results when displaying the object level permissions.

@kraenhansen kraenhansen self-assigned this Sep 27, 2019
@kraenhansen kraenhansen merged commit 2448200 into master Sep 27, 2019
@kraenhansen kraenhansen deleted the kh/permissions-sidebar-filtered branch September 27, 2019 12:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kraenhansen kraenhansen

Labels
T-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission sidebar of the browser maps incorrectly when filtering the table
2 participants
@kraenhansen @realm-ci