Allow more powerful queries for Realms/Users tables #1147
Conversation
| @@ -81,8 +83,9 @@ export const RealmsTable = ({ | |||
| onElementDoubleClick={onRealmOpened} | |||
| onElementsDeselection={onRealmsDeselection} | |||
| onSearchStringChange={onSearchStringChange} | |||
| searchPlaceholder="Search Realms" | |||
| searchPlaceholder="Search Realms (start with ! to write a verbatim realm-js query)" | |||
There was a problem hiding this comment.
I believe this placeholder is a bit (too) cryptic - perhaps we could move this explanation, with a couple of examples to a tooltip which is shown when pressing "?" button at the end of the input field or perhaps a placeholder in the table when the query doesn't return any results?
There was a problem hiding this comment.
@nirinchev I see now that my comment doesn't make that much sense, as you did in-fact add a tooltip with examples 😄I think this placeholder can be greatly simplified as we have that.
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } |
There was a problem hiding this comment.
Not a big fan of this change @nirinchev.
Having a pre-commit hook makes it easier to help contributors remember to run linting.
If you think this was really necessary, I think it should have been a separate PR to make it easier to revert in the future.
There was a problem hiding this comment.
I couldn't commit due to an error that I showed you some time ago. While I agree it could have been done in a separate PR, it didn't seem worth the effort. I'll create an issue to track enabling it.
There was a problem hiding this comment.
☝️ did you create an issue to track enabling it @nirinchev? I can't seem to find it ..
There was a problem hiding this comment.
Of course - #1166 - it's the latest issue in the repo 😝
Fixes #1146
Some screens: