Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink Objective-C superclass in class declaration #708

Closed
wants to merge 1 commit into from

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Dec 19, 2016

In Objective-C class declarations, autolink the superclass if possible.

Fixes #706.

/cc @friedbunny @tmcw

@jpsim
Copy link
Collaborator

jpsim commented Dec 19, 2016

Thanks for the PR!

Could you please add a sample exercising this bug fix in the misc_jazzy_objc_features integration spec? Fix and changelog entry both look good though! 👌

@1ec5 1ec5 force-pushed the 1ec5-objc-superclass-706 branch from c70fb89 to 0c7e21c Compare December 21, 2016 10:06
@1ec5 1ec5 force-pushed the 1ec5-objc-superclass-706 branch from 0c7e21c to cc2256e Compare December 21, 2016 12:34
@1ec5 1ec5 requested a review from jpsim December 21, 2016 12:36
@jpsim
Copy link
Collaborator

jpsim commented Dec 21, 2016

This looks great @1ec5, I've rebuilt the integration specs and will be merging in #713.

@jpsim jpsim closed this Dec 21, 2016
@1ec5 1ec5 deleted the 1ec5-objc-superclass-706 branch December 21, 2016 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants