-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty_parentheses_with_trailing_closure rule #958
Conversation
] | ||
) | ||
|
||
public enum Kind: String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the second place where this enum is needed and the 3rd where "source.lang.swift.expr.call"
is used. Should we create a shared enum? If so, where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! This should live in SourceKittenFramework though.
return [] | ||
} | ||
|
||
let rangeStart = nameOffset + nameLength |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using bodyOffset and bodyLength were giving incorrect ranges ¯_(ツ)_/¯
Current coverage is 83.96% (diff: 100%)@@ master #958 diff @@
==========================================
Files 120 121 +1
Lines 5517 5552 +35
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4627 4662 +35
Misses 890 890
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 💯. Top notch implementation. You're a pro, @marcelofabri!
🎉 🚢 |
Fixes #885