Add empty_parentheses_with_trailing_closure rule #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
commented
Dec 11, 2016
| ] | ||
| ) | ||
|
|
||
| public enum Kind: String { |
There was a problem hiding this comment.
this is the second place where this enum is needed and the 3rd where "source.lang.swift.expr.call" is used. Should we create a shared enum? If so, where?
There was a problem hiding this comment.
Yes! This should live in SourceKittenFramework though.
marcelofabri
commented
Dec 11, 2016
| return [] | ||
| } | ||
|
|
||
| let rangeStart = nameOffset + nameLength |
There was a problem hiding this comment.
using bodyOffset and bodyLength were giving incorrect ranges ¯_(ツ)_/¯
Current coverage is 83.96% (diff: 100%)@@ master #958 diff @@
==========================================
Files 120 121 +1
Lines 5517 5552 +35
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4627 4662 +35
Misses 890 890
Partials 0 0
|
jpsim
approved these changes
Dec 11, 2016
There was a problem hiding this comment.
👌 💯. Top notch implementation. You're a pro, @marcelofabri!
|
🎉 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #885