Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback if swiftlint fails #865

Closed
wants to merge 1 commit into from
Closed

Conversation

dostrander
Copy link

  • Currently swiftlint fails if you are on a old version of it. There should be a fallback when it fails and some type of recommended next step.

@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 85.67% (diff: 100%)

Merging #865 into master will not change coverage

@@             master       #865   diff @@
==========================================
  Files           108        108          
  Lines          4767       4767          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4084       4084          
  Misses          683        683          
  Partials          0          0          

Powered by Codecov. Last update 2246bb9...70b796f

@jpsim
Copy link
Collaborator

jpsim commented Nov 25, 2016

This isn't quite right. For one, swiftlint || echo "..." will always have a return code of 0.

Even if that were addressed, always logging "Is SwiftLint installed and up to date?" no matter of the reason of the failure is misleading.

Seems like overall, this PR aims to address a larger issue, which is one of version enforcement and compatibility, for which discussions around potential strategies to resolve are actively happening in #221. I'd prefer focusing our energies on finding a good solution.

@jpsim jpsim closed this Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants