Rewrite ExplicitInitRule as ASTRule
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.71% (diff: 92.98%)@@ master #826 diff @@
==========================================
Files 105 106 +1
Lines 4332 4389 +57
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3665 3718 +53
- Misses 667 671 +4
Partials 0 0
|
norio-nomura
added
the
enhancement
norio-nomura
force-pushed
the
rewrite-explicit-init-rule-to-astrule
branch
from
d3e556d
to
9b64c7d
Compare
norio-nomura
changed the title
ExplicitInitRule to ASTRuleExplicitInitRule as ASTRule
This was referenced Oct 29, 2016
Closed
|
Seems ok. Thanks, @norio-nomura and @mtaube |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite #715 as
ASTRulefor reducing false positive./cc: @mtaube, @jpsim