Use whitespace around operator definitions. #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f799880.
| @@ -48,7 +48,7 @@ Returns true if `lhs` Location is equal to `rhs` Location. | |||
|
|
|||
| :returns: True if `lhs` Location is equal to `rhs` Location. | |||
| */ | |||
| public func ==(lhs: Location, rhs: Location) -> Bool { | |||
| public func == (lhs: Location, rhs: Location) -> Bool { | |||
|
This is really nice work, @akirahrkw! I just had a few minor comments, let me know what you think, then we'll merge this in. |
|
thanks for your feedback. I just pushed the change:) |
|
I made a few changes to your work in #83 to support multibyte characters & specify only a single space on each side of the operator. So I'm closing this in favor of #83. Very nice work on this, @akirahrkw! |
|
got it and thank you:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is about "Use whitespace around operator definitions."
#60
thanks:)