Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: void_function_in_ternary incorrectly triggered with if statement #5674

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

u-abyss
Copy link
Contributor

@u-abyss u-abyss commented Jul 15, 2024

Fixes #5611

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 15, 2024

1 Error
🚫 Please rebase to get rid of the merge commits in this PR
2 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
17 Messages
📖 Linting Aerial with this PR took 0.14s vs 0.14s on main (0% slower)
📖 Linting Alamofire with this PR took 0.14s vs 0.14s on main (0% slower)
📖 Linting Brave with this PR took 0.57s vs 0.57s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Firefox with this PR took 1.15s vs 1.15s on main (0% slower)
📖 Linting Kickstarter with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting Moya with this PR took 0.1s vs 0.1s on main (0% slower)
📖 Linting NetNewsWire with this PR took 0.24s vs 0.25s on main (4% faster)
📖 Linting Nimble with this PR took 0.11s vs 0.12s on main (8% faster)
📖 Linting PocketCasts with this PR took 0.58s vs 0.58s on main (0% slower)
📖 Linting Quick with this PR took 0.1s vs 0.1s on main (0% slower)
📖 Linting Realm with this PR took 0.39s vs 0.39s on main (0% slower)
📖 Linting Sourcery with this PR took 0.25s vs 0.25s on main (0% slower)
📖 Linting Swift with this PR took 0.37s vs 0.37s on main (0% slower)
📖 Linting VLC with this PR took 0.17s vs 0.17s on main (0% slower)
📖 Linting Wire with this PR took 1.5s vs 1.5s on main (0% slower)
📖 Linting WordPress with this PR took 0.96s vs 0.96s on main (0% slower)

Here's an example of your CHANGELOG entry:

* fix: void_function_in_ternary incorrectly triggered with if statement.  
  [u-abyss](https://github.com/u-abyss)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

void_function_in_ternary incorrectly triggered with if and switch expressions
2 participants