Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure frameworks #5482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

Ideally, SwiftLintCore would only contain components that are needed to define rules. Consequently, it would be the only bundle required to import for (external) rule development.

There are a few other components left in SwiftLintCore that could potentially be moved to SwiftLintFramework someday. However, this requires preparing some other refactorings first.

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 4, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 1.14s vs 1.13s on main (0% slower)
📖 Linting Alamofire with this PR took 1.63s vs 1.62s on main (0% slower)
📖 Linting Brave with this PR took 9.43s vs 9.42s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.94s vs 4.91s on main (0% slower)
📖 Linting Firefox with this PR took 12.84s vs 12.72s on main (0% slower)
📖 Linting Kickstarter with this PR took 11.41s vs 11.3s on main (0% slower)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.1s vs 3.09s on main (0% slower)
📖 Linting Nimble with this PR took 0.92s vs 0.92s on main (0% slower)
📖 Linting PocketCasts with this PR took 9.13s vs 9.11s on main (0% slower)
📖 Linting Quick with this PR took 0.43s vs 0.41s on main (4% slower)
📖 Linting Realm with this PR took 5.75s vs 5.77s on main (0% faster)
📖 Linting Sourcery with this PR took 2.8s vs 2.79s on main (0% slower)
📖 Linting Swift with this PR took 5.62s vs 5.58s on main (0% slower)
📖 Linting VLC with this PR took 1.51s vs 1.52s on main (0% faster)
📖 Linting Wire with this PR took 21.33s vs 21.19s on main (0% slower)
📖 Linting WordPress with this PR took 13.84s vs 13.72s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Restructure frameworks.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Ideally, SwiftLintCore would some day only contain components
that are needed to define rules. Consequently, it would be the
only bundle required to import for (external) rule development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants