Improve performance of ColonRule
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'll rebase this and merge. |
The duration of `ColonRule` on linting Carthage 0.13 is reduced from 1673ms to 515ms by Instruments.
jpsim
force-pushed
the
nn-optimize-colon-rule
branch
from
a2e9bbc
to
83c0085
Compare
also align regex pattern comments & fix indentation
|
Thanks for reviews and naming! 😄 |
jpsim
added a commit
that referenced
this pull request
Feb 10, 2016
Improve performance of `ColonRule`
|
👍 nice perf boost! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration of
ColonRuleon linting Carthage 0.13 is reduced from 1673ms to 515ms by Instruments.from:
to: