Return an error status code if serious violations found #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Xcode compatibility.
| public var xcodeSeverityDescription: String { | ||
| return self <= Medium ? "warning" : "error" | ||
| return self.isError ? "error" : "warning" |
There was a problem hiding this comment.
please omit the self keyword here. (it'd be nice to add a rule for this at some point 😄)
|
Thanks for doing this! The PR looks good, other than my one point about Could you also add an entry to the CHANGELOG under "Enhancements" so we can properly attribute the change to you? |
|
Thanks for the feedback. I've removed the 'self' reference and updated the change log. |
|
Thanks! |
jpsim
added a commit
that referenced
this pull request
May 24, 2015
Return an error status code if serious violations found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #30
This mingles errors due to swiftlint issues with errors in the files swiftlint is auditing. We lose information doing that, but otherwise we'd need to re-architect the Command structure and I don't think that's possible right now.
This is my first go at creating GitHub pull requests, so please let me know if I'm doing anything wrong.