[Speedup] [Proof Of Concept] Use unique file Id for each SiwftLintFile for caching #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulTaykalo
added
enhancement
PaulTaykalo
commented
Oct 29, 2019
| @@ -0,0 +1,56 @@ | |||
| import Foundation | |||
There was a problem hiding this comment.
This one is mostly what this suggestion about
PaulTaykalo
commented
Oct 29, 2019
| @@ -1,9 +1,10 @@ | |||
| import Foundation | |||
| import SourceKittenFramework | |||
|
|
|||
| private typealias FileCacheKey = Int | |||
|
The main question here whether it is appropriate or allowable to make changes like this one :) |
Generated by 🚫 Danger |
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
49f2a39
to
f4f6945
Compare
While this is true, it's really hard to clear all caches if we go that direction. |
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
2 times, most recently
from
8087127
to
4e8fa64
Compare
PaulTaykalo
changed the title
|
This one is probably, the most we can take out in terms of speed from SwiftLint not touching regular expressions. @jpsim @marcelofabri Please, review |
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
f46a6fd
to
0955124
Compare
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
4daac6e
to
b16f8a8
Compare
|
@jpsim ping? |
PaulTaykalo
force-pushed
the
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
branch
from
6497350
to
b1cdc11
Compare
PaulTaykalo
changed the base branch from
speedup/use-swift-declaration-kinds-enums-instead-of-rawValues
to
master
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
b16f8a8
to
2e8e80f
Compare
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
2e8e80f
to
d771d22
Compare
PaulTaykalo
force-pushed
the
speedup/test-use-cache-as-int
branch
from
d5a16c3
to
a8d90eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
How about having unique key per file?
This can be done in a lot of ways, one of these. is below.
A suggested solution is to have own wrapper over
Filewhich will allow storing additional data per file.What
Change the way how files information is cached in Swiftlint
Why
Speedup mostly
Note
In general, swiftlint is using
contentsorpathas cacheKey. Unfortunately using keys so big is slow.Using simple, fast, unique cacheKey, allows speed up running time.
On the Image. Most of the time spent in
Dictionary.getteris actually callingCache.get(file.cacheKey)The worst-case scenario for this one is to have multiple files with identical contents. which is not-really li
Alternatives