Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @ mark to fix invalid link in Rules.md #2669

Merged

Conversation

pixyzehn
Copy link
Contributor

@pixyzehn pixyzehn commented Mar 6, 2019

Removed punctuation before replacing whitespace with -.

I took a look at how Github markup works to create named anchors. It said The resulting HTML is rendered on GitHub.com. here.

So, based on what Github markup used before, I followed the way jch/html-pipeline takes. What do you think? Do you have any idea for that?

ref:

@marcelofabri
Copy link
Collaborator

This file is autogenerated, so we need to fix it in code

@marcelofabri
Copy link
Collaborator

More specifically, this is done in RuleList+Documentation.swift

@pixyzehn
Copy link
Contributor Author

pixyzehn commented Mar 7, 2019

@marcelofabri Thank you! Will check the file and try to fix it.

@pixyzehn
Copy link
Contributor Author

pixyzehn commented Mar 9, 2019

Just updated the description of this PR.

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 9, 2019

12 Messages
📖 Linting Aerial with this PR took 1.82s vs 1.79s on master (1% slower)
📖 Linting Alamofire with this PR took 3.89s vs 3.9s on master (0% faster)
📖 Linting Firefox with this PR took 12.3s vs 12.37s on master (0% faster)
📖 Linting Kickstarter with this PR took 19.8s vs 20.55s on master (3% faster)
📖 Linting Moya with this PR took 1.86s vs 1.84s on master (1% slower)
📖 Linting Nimble with this PR took 1.75s vs 1.75s on master (0% slower)
📖 Linting Quick with this PR took 0.55s vs 0.56s on master (1% faster)
📖 Linting Realm with this PR took 3.33s vs 3.37s on master (1% faster)
📖 Linting SourceKitten with this PR took 1.12s vs 1.12s on master (0% slower)
📖 Linting Sourcery with this PR took 4.03s vs 4.2s on master (4% faster)
📖 Linting Swift with this PR took 27.08s vs 26.91s on master (0% slower)
📖 Linting WordPress with this PR took 21.37s vs 21.12s on master (1% slower)

Generated by 🚫 Danger

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@marcelofabri marcelofabri merged commit 9fc1d57 into realm:master Mar 13, 2019
@pixyzehn pixyzehn deleted the fix-link-for-redundant-@objc-attribute branch March 13, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants