Opt-in rule to check for redundant type annotations #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
==========================================
+ Coverage 92.03% 92.06% +0.02%
==========================================
Files 283 284 +1
Lines 14244 14296 +52
==========================================
+ Hits 13110 13161 +51
- Misses 1134 1135 +1
Continue to review full report at Codecov.
|
marcelofabri
approved these changes
Jul 19, 2018
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule checks for redundant type annotations, e.g.
var view: UIView = UIView(). Violations are only triggered when it is the same type (e.g.,view: UIControl = UIView()will not trigger). Basically, it's the opposite ofExplicitTypeInterfaceRule.This is my first rule and my first ever pull request on github, so feedback is welcome.