-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pattern_matching_keywords rule #1800
Conversation
Looks like this one is a false positive: |
@Uncommon I don't see why. You should use this instead: case let (.deviceConnected(lName), .deviceConnected(rName)): |
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
==========================================
+ Coverage 88.21% 88.23% +0.01%
==========================================
Files 224 225 +1
Lines 11068 11100 +32
==========================================
+ Hits 9764 9794 +30
- Misses 1304 1306 +2
Continue to review full report at Codecov.
|
@marcelofabri Ah, I see. Never mind. |
439fd0d
to
571510c
Compare
571510c
to
1d68a8d
Compare
Closes #202.
This rule should also be applied in other cases of pattern matching, but I guess supporting only
switch
es is reasonable for now.Let's see how much oss-check complains to decide if this should be opt-in or enabled by default.