Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern_matching_keywords rule #1800

Merged
merged 3 commits into from
Aug 26, 2017
Merged

Conversation

marcelofabri
Copy link
Collaborator

Closes #202.

This rule should also be applied in other cases of pattern matching, but I guess supporting only switches is reasonable for now.

Let's see how much oss-check complains to decide if this should be opt-in or enabled by default.

@SwiftLintBot
Copy link

SwiftLintBot commented Aug 25, 2017

203 Warnings
⚠️ Make sure that the docs are updated by running the Generate docs scheme.
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L388:49: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L388:58: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L397:52: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L397:61: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L451:39: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/AFError.swift#L451:60: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L132:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L132:38: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L135:24: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L135:42: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L138:22: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L138:40: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L141:22: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Alamofire: /Source/Request.swift#L141:40: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L262:32: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L262:61: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L264:34: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Account/FxAPushMessageHandler.swift#L264:65: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Providers/SyncStatusResolver.swift#L42:16: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Providers/SyncStatusResolver.swift#L42:29: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Providers/SyncStatusResolver.swift#L44:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Providers/SyncStatusResolver.swift#L44:37: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L105:11: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L105:42: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L108:11: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L108:38: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L111:11: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L111:39: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L114:11: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Firefox: /Sync/State.swift#L114:40: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L13:18: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L13:31: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L18:18: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L18:31: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L18:52: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/DataSources/LiveStreamContainerPagesDataSource.swift#L18:64: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Library/LiveStreamTypes.swift#L62:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Library/LiveStreamTypes.swift#L62:51: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Library/LiveStreamTypes.swift#L64:18: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Kickstarter: /Library/LiveStreamTypes.swift#L64:40: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L125:35: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L125:51: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L129:28: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L129:48: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L160:30: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L160:42: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Nimble: /Tests/NimbleTests/Matchers/ThrowErrorTest.swift#L18:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Nimble: /Tests/NimbleTests/Matchers/ThrowErrorTest.swift#L18:49: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/LinkingObjects.swift#L424:15: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/LinkingObjects.swift#L424:54: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/RealmCollectionTypeTests.swift#L656:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/RealmCollectionTypeTests.swift#L656:39: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/RealmCollectionTypeTests.swift#L656:54: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Realm: /RealmSwift/Tests/RealmCollectionTypeTests.swift#L656:70: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/JSONOutput.swift#L122:16: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/JSONOutput.swift#L122:25: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L237:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L237:36: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L237:48: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L250:37: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L250:47: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L250:61: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L250:73: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L275:23: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L275:33: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L281:21: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L281:31: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L288:22: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L288:32: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L288:42: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L288:55: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L303:27: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L303:37: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L303:49: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L303:61: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L311:23: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L311:33: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L319:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L319:38: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/RaceTest.swift#L141:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/private/StdlibUnittest/RaceTest.swift#L141:52: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ClosedRange.swift#L69:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ClosedRange.swift#L69:37: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ClosedRange.swift#L84:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/ClosedRange.swift#L84:37: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L456:27: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L456:51: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L457:27: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L457:51: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L463:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L463:47: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L464:20: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L464:47: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L466:31: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L466:66: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L467:31: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L467:66: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L469:34: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L469:69: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L470:34: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L470:69: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L526:19: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L526:45: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L530:30: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L530:64: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L534:33: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L534:67: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1014:27: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1014:49: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1015:38: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1015:68: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1016:41: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1016:71: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1079:38: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1079:55: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1080:36: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1102:41: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1102:58: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/KeyPath.swift#L1103:39: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Unicode.swift#L39:24: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Unicode.swift#L39:53: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Dispatch/Data.swift#L36:17: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Dispatch/Data.swift#L36:24: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L63:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L63:47: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L65:26: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L65:45: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L67:24: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ This PR introduced a violation in Swift: /stdlib/public/SDK/Foundation/CharacterSet.swift#L67:45: warning: Pattern Matching Keywords Violation: Combine multiple pattern matching bindings by moving keywords out of tuples. (pattern_matching_keywords)
⚠️ Danger found 203 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 130.
12 Messages
📖 Linting Aerial with this PR took 0.38s vs 0.35s on master (8% slower)
📖 Linting Alamofire with this PR took 2.4s vs 2.4s on master (0% slower)
📖 Linting Firefox with this PR took 10.15s vs 10.25s on master (0% faster)
📖 Linting Kickstarter with this PR took 15.61s vs 15.51s on master (0% slower)
📖 Linting Moya with this PR took 1.05s vs 1.05s on master (0% slower)
📖 Linting Nimble with this PR took 1.38s vs 1.37s on master (0% slower)
📖 Linting Quick with this PR took 0.45s vs 0.46s on master (2% faster)
📖 Linting Realm with this PR took 2.37s vs 2.18s on master (8% slower)
📖 Linting SourceKitten with this PR took 0.85s vs 0.86s on master (1% faster)
📖 Linting Sourcery with this PR took 3.65s vs 3.65s on master (0% slower)
📖 Linting Swift with this PR took 9.95s vs 10.04s on master (0% faster)
📖 Linting WordPress with this PR took 9.24s vs 9.29s on master (0% faster)

Generated by 🚫 Danger

@Uncommon
Copy link
Contributor

@marcelofabri
Copy link
Collaborator Author

@Uncommon I don't see why. You should use this instead:

case let (.deviceConnected(lName), .deviceConnected(rName)):

@codecov-io
Copy link

codecov-io commented Aug 25, 2017

Codecov Report

Merging #1800 into master will increase coverage by 0.01%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
+ Coverage   88.21%   88.23%   +0.01%     
==========================================
  Files         224      225       +1     
  Lines       11068    11100      +32     
==========================================
+ Hits         9764     9794      +30     
- Misses       1304     1306       +2
Impacted Files Coverage Δ
Source/SwiftLintFramework/Models/YamlParser.swift 87.8% <100%> (ø) ⬆️
...urce/SwiftLintFramework/Models/Configuration.swift 87.33% <100%> (ø) ⬆️
...ntFramework/Extensions/Configuration+Merging.swift 85.26% <100%> (ø) ⬆️
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...tFramework/Rules/PatternMatchingKeywordsRule.swift 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c5565...1d68a8d. Read the comment docs.

@Uncommon
Copy link
Contributor

@marcelofabri Ah, I see. Never mind.

@marcelofabri marcelofabri merged commit b1c7063 into master Aug 26, 2017
@marcelofabri marcelofabri deleted the mf-pattern_matching_keywords branch August 26, 2017 14:05
@jpsim jpsim mentioned this pull request Sep 9, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants